net/cert/cert_verify_proc_win.cc - Issue 1683673002: Fix -Wsign-compare warning after https://codereview.chromium.org/1557133002

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/cert_verify_proc_win.cc

Issue 1683673002: Fix -Wsign-compare warning after https://codereview.chromium.org/1557133002 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cert/cert_verify_proc_win.cc

diff --git a/net/cert/cert_verify_proc_win.cc b/net/cert/cert_verify_proc_win.cc

index 0013046815142dff687b2229191f4dae225eb831..18c6187cb1bb700686d78bd24a75f4b6cd38a055 100644

--- a/net/cert/cert_verify_proc_win.cc

+++ b/net/cert/cert_verify_proc_win.cc

@@ -804,7 +804,7 @@ CertDllVerifyRevocationWithCRLSet(DWORD encoding_type,

}

if (issuer_cert)

break;

- if (GetLastError() == CRYPT_E_SELF_SIGNED) {

+ if (GetLastError() == static_cast<DWORD>(CRYPT_E_SELF_SIGNED)) {

issuer_cert.reset(CertDuplicateCertificateContext(subject_cert));

break;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »