Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 1683653002: Add a generic remembered set class. (Closed)

Created:
4 years, 10 months ago by ulan
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add a generic remembered set class. This new class provides a unified interface for recording and iterating slots in store and slots buffers: RememberedSet<OLD_TO_NEW>::Insert(page, slot); RememberedSet<OLD_TO_OLD>::Insert(page, slot); RememberedSet<OLD_TO_NEW>::Iterate(heap, callback); RememberedSet<OLD_TO_OLD>::Iterate(heap, callback); After this change the store buffer is responsible only for collecting slots from the generated code. Subsequent CLs will remove the slots buffer. BUG=chromium:578883 LOG=NO Committed: https://crrev.com/4fdc19ae33cfb4c9b957585ec35f7dfb6f67177f Cr-Commit-Position: refs/heads/master@{#34031}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 2

Patch Set 7 : #

Total comments: 11

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -263 lines) Patch
M BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 5 6 7 7 chunks +11 lines, -9 lines 0 comments Download
M src/heap/heap-inl.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 4 5 6 5 chunks +6 lines, -5 lines 0 comments Download
A src/heap/remembered-set.h View 1 2 3 4 5 1 chunk +143 lines, -0 lines 0 comments Download
A src/heap/remembered-set.cc View 1 2 3 4 5 1 chunk +69 lines, -0 lines 0 comments Download
M src/heap/slot-set.h View 4 chunks +8 lines, -4 lines 0 comments Download
M src/heap/spaces.h View 1 2 3 4 5 6 7 6 chunks +10 lines, -1 line 0 comments Download
M src/heap/spaces.cc View 1 2 3 4 5 6 7 3 chunks +21 lines, -6 lines 0 comments Download
M src/heap/spaces-inl.h View 1 2 3 4 5 6 7 1 chunk +9 lines, -15 lines 0 comments Download
M src/heap/store-buffer.h View 1 2 3 4 chunks +6 lines, -43 lines 0 comments Download
M src/heap/store-buffer.cc View 1 2 1 chunk +4 lines, -152 lines 0 comments Download
M src/heap/store-buffer-inl.h View 1 2 2 chunks +4 lines, -27 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
ulan
PTAL https://codereview.chromium.org/1683653002/diff/100001/src/heap/store-buffer.cc File src/heap/store-buffer.cc (left): https://codereview.chromium.org/1683653002/diff/100001/src/heap/store-buffer.cc#oldcode89 src/heap/store-buffer.cc:89: heap_->InNewSpace(object); This verifies only large objects space and ...
4 years, 10 months ago (2016-02-11 15:24:33 UTC) #4
Hannes Payer (out of office)
LGTM, just minor things. https://codereview.chromium.org/1683653002/diff/120001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1683653002/diff/120001/src/heap/heap.cc#newcode4492 src/heap/heap.cc:4492: // the store buffer. These ...
4 years, 10 months ago (2016-02-15 16:53:39 UTC) #5
ulan
Thanks for the comments. https://codereview.chromium.org/1683653002/diff/120001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1683653002/diff/120001/src/heap/heap.cc#newcode4492 src/heap/heap.cc:4492: // the store buffer. These ...
4 years, 10 months ago (2016-02-16 10:24:52 UTC) #6
Hannes Payer (out of office)
lgtm, ship it https://codereview.chromium.org/1683653002/diff/120001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1683653002/diff/120001/src/heap/heap.cc#newcode5485 src/heap/heap.cc:5485: Page* page = Page::FromAddress(slot_addr); On 2016/02/16 ...
4 years, 10 months ago (2016-02-16 12:00:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683653002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683653002/140001
4 years, 10 months ago (2016-02-16 12:06:29 UTC) #9
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 10 months ago (2016-02-16 12:34:35 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 12:34:49 UTC) #13
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/4fdc19ae33cfb4c9b957585ec35f7dfb6f67177f
Cr-Commit-Position: refs/heads/master@{#34031}

Powered by Google App Engine
This is Rietveld 408576698