Raise exceptions properly on HTTP errors from OAuthRpcServer (which is only used on bots)

Raise exceptions properly on HTTP errors from OAuthRpcServer (which is only used on bots)

This will hopefully make Rietveld._send retry 500s like it promises to

BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298688

[dsansome, 2016-02-09 05:09:22]

dsansome@chromium.org changed reviewers:
+ agable@chromium.org

[agable, 2016-02-09 19:13:04]

lgtm

[dsansome, 2016-02-09 23:14:57]

The CQ bit was checked by dsansome@chromium.org

[commit-bot: I haz the power, 2016-02-09 23:15:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1683603002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1683603002/1

[commit-bot: I haz the power, 2016-02-09 23:17:17]

Description was changed from

==========
Raise exceptions properly on HTTP errors from OAuthRpcServer (which is only used
on bots)

This will hopefully make Rietveld._send retry 500s like it promises to

BUG=
==========

to

==========
Raise exceptions properly on HTTP errors from OAuthRpcServer (which is only used
on bots)

This will hopefully make Rietveld._send retry 500s like it promises to

BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298688
==========

[commit-bot: I haz the power, 2016-02-09 23:17:18]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298688

[Vadim Sh., 2016-02-09 23:56:41]

vadimsh@chromium.org changed reviewers:
+ vadimsh@chromium.org

[Vadim Sh., 2016-02-09 23:56:41]

This probable broke how depot_tools interacts with internal Rietveld. See
https://code.google.com/p/chromium/issues/detail?id=585632 and
https://uberchromegw.corp.google.com/i/internal.infra.try/builders/chrome-gol...
for instances I saw:

DEBUG    rietveld( 418): /356847013/patchset/1/get_depends_on_patchset
Traceback (most recent call last):
  File "/mnt/data/b/depot_tools/apply_issue.py", line 323, in <module>
    sys.exit(main())
  File "/mnt/data/b/depot_tools/apply_issue.py", line 194, in main
    options.issue, options.patchset)
  File "/mnt/data/b/depot_tools/rietveld.py", line 95, in
get_depends_on_patchset
    resp = json.loads(self.post(url, []))
  File "/mnt/data/b/depot_tools/rietveld.py", line 394, in post
    return self._send(request_path, payload=body, content_type=ctype, **kwargs)
  File "/mnt/data/b/depot_tools/rietveld.py", line 457, in _send
    print 'Request to %s failed: %s' % (e.geturl(), e.read())
  File "/usr/lib/python2.7/urllib.py", line 1019, in geturl
    return self.url
AttributeError: 'HTTPError' object has no attribute 'url'

[dsansome, 2016-02-10 00:00:03]

On 2016/02/09 23:56:41, Vadim Sh. wrote:
> This probable broke how depot_tools interacts with internal Rietveld. See
> https://code.google.com/p/chromium/issues/detail?id=585632 and
>
https://uberchromegw.corp.google.com/i/internal.infra.try/builders/chrome-gol...
> for instances I saw:
> 
> DEBUG    rietveld( 418): /356847013/patchset/1/get_depends_on_patchset
> Traceback (most recent call last):
>   File "/mnt/data/b/depot_tools/apply_issue.py", line 323, in <module>
>     sys.exit(main())
>   File "/mnt/data/b/depot_tools/apply_issue.py", line 194, in main
>     options.issue, options.patchset)
>   File "/mnt/data/b/depot_tools/rietveld.py", line 95, in
> get_depends_on_patchset
>     resp = json.loads(self.post(url, []))
>   File "/mnt/data/b/depot_tools/rietveld.py", line 394, in post
>     return self._send(request_path, payload=body, content_type=ctype,
**kwargs)
>   File "/mnt/data/b/depot_tools/rietveld.py", line 457, in _send
>     print 'Request to %s failed: %s' % (e.geturl(), e.read())
>   File "/usr/lib/python2.7/urllib.py", line 1019, in geturl
>     return self.url
> AttributeError: 'HTTPError' object has no attribute 'url'

Uh oh, I'll roll it back and investigate