Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 16836015: Rebaseline bindings test results after r152270 (Closed)

Created:
7 years, 6 months ago by do-not-use
Modified:
7 years, 6 months ago
CC:
blink-reviews, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, lgombos
Visibility:
Public.

Description

Rebaseline bindings test results after r152270 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152350

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -74 lines) Patch
M Source/bindings/tests/results/V8Float64Array.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestCustomAccessors.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.cpp View 2 chunks +25 lines, -25 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 3 chunks +18 lines, -12 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
do-not-use
7 years, 6 months ago (2013-06-13 12:17:47 UTC) #1
haraken
LGTM.
7 years, 6 months ago (2013-06-13 12:18:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/16836015/1
7 years, 6 months ago (2013-06-13 12:18:37 UTC) #3
commit-bot: I haz the power
Change committed as 152350
7 years, 6 months ago (2013-06-13 12:18:54 UTC) #4
Stephen White
Nit: this looks like a code change, not a rebaseline. If so, it probably shouldn't ...
7 years, 6 months ago (2013-06-13 14:28:51 UTC) #5
Stephen White
7 years, 6 months ago (2013-06-13 14:30:13 UTC) #6
Message was sent while issue was closed.
On 2013/06/13 14:28:51, Stephen White wrote:
> Nit: this looks like a code change, not a rebaseline. If so, it probably
> shouldn't have landed with NOTRY=true.

Never mind; I see now that the code changes are in bindings/tests.

Powered by Google App Engine
This is Rietveld 408576698