Preserve argument count for calls.

Preserve argument count for calls.

Calls use registers for target, new_target and argument count.
We don't always respect argument count. It didn't bite us in the past
because the code paths where we clobbered it never used it, though
in future it could be an issue.

BUG=
R=mstarzinger@chromium.org

Committed: https://crrev.com/5de27c343bbf898ca87246caa1e83e533ec44561
Cr-Commit-Position: refs/heads/master@{#33865}

[Michael Starzinger, 2016-02-09 11:52:20]

https://codereview.chromium.org/1683593003/diff/1/src/ia32/builtins-ia32.cc
File src/ia32/builtins-ia32.cc (right):

https://codereview.chromium.org/1683593003/diff/1/src/ia32/builtins-ia32.cc#n...
src/ia32/builtins-ia32.cc:65: Register output) {
Instead of passing an output register this function, we could merge it entirely
into GenerateTailCallToReturnedCode which internally can preserve the eax
register. So in the end we would have two function. WDYT?

static void GenerateTailCallToSharedCode(MacroAssembler* masm);

static void GenerateTailCallToReturnedCode(MacroAssembler* masm,
                                           Runtime::FunctionId function_id);

[mvstanton, 2016-02-09 18:47:47]

Thanks for the comments Michael.
Here are the ports too,
Best,
--Mike

https://codereview.chromium.org/1683593003/diff/1/src/ia32/builtins-ia32.cc
File src/ia32/builtins-ia32.cc (right):

https://codereview.chromium.org/1683593003/diff/1/src/ia32/builtins-ia32.cc#n...
src/ia32/builtins-ia32.cc:65: Register output) {
On 2016/02/09 11:52:19, Michael Starzinger wrote:
> Instead of passing an output register this function, we could merge it
entirely
> into GenerateTailCallToReturnedCode which internally can preserve the eax
> register. So in the end we would have two function. WDYT?
> 
> static void GenerateTailCallToSharedCode(MacroAssembler* masm);
> 
> static void GenerateTailCallToReturnedCode(MacroAssembler* masm,
>                                            Runtime::FunctionId function_id);

Most excellent idea, thanks!

[Michael Starzinger, 2016-02-10 12:56:09]

LGTM. Nice. Thanks!

[mvstanton, 2016-02-10 13:25:23]

The CQ bit was checked by mvstanton@chromium.org

[commit-bot: I haz the power, 2016-02-10 13:25:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1683593003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1683593003/80001

[commit-bot: I haz the power, 2016-02-10 13:35:55]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-10 13:36:12]

Description was changed from

==========
Preserve argument count for calls.

Calls use registers for target, new_target and argument count.
We don't always respect argument count. It didn't bite us in the past
because the code paths where we clobbered it never used it, though
in future it could be an issue.

BUG=
R=mstarzinger@chromium.org
==========

to

==========
Preserve argument count for calls.

Calls use registers for target, new_target and argument count.
We don't always respect argument count. It didn't bite us in the past
because the code paths where we clobbered it never used it, though
in future it could be an issue.

BUG=
R=mstarzinger@chromium.org

Committed: https://crrev.com/5de27c343bbf898ca87246caa1e83e533ec44561
Cr-Commit-Position: refs/heads/master@{#33865}
==========

[commit-bot: I haz the power, 2016-02-10 13:36:13]

Patchset 5 (id:??) landed as
https://crrev.com/5de27c343bbf898ca87246caa1e83e533ec44561
Cr-Commit-Position: refs/heads/master@{#33865}