Don't use pending NavigationEntries for navigation transfers.

content/browser/frame_host/navigation_controller_impl_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigation_controller_impl.h"
 
 #include <stdint.h>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 489 matching lines @@
   script = "var iframe = document.createElement('iframe');"
            "iframe.src = 'data:text/html,<p>some page</p>';"
            "document.body.appendChild(iframe);";
   EXPECT_TRUE(content::ExecuteScript(new_root->current_frame_host(), script));
   // The success check is of the last-committed entry, and there is none.
   WaitForLoadStopWithoutSuccessCheck(new_shell->web_contents());
 
   ASSERT_EQ(1U, new_root->child_count());
   ASSERT_NE(nullptr, new_root->child_at(0));
 
-  // Navigate it.
+  // Navigate it cross-site.
   GURL frame_url = embedded_test_server()->GetURL(
-      "/navigation_controller/simple_page_2.html");
+      "foo.com", "/navigation_controller/simple_page_2.html");
   script = "location.assign('" + frame_url.spec() + "')";
   EXPECT_TRUE(content::ExecuteScript(
       new_root->child_at(0)->current_frame_host(), script));
+  WaitForLoadStopWithoutSuccessCheck(new_shell->web_contents());

[Charlie Reis, 2016/03/30 15:26:08]

Before the change in this CL, doing this crashes in LoadURLWithParams on the
GetLastCommittedEntry()->Clone() line (at least in OOPIF-enabled modes).  We
need the wait line to let the navigation get to the transfer and thus crash.

In fact, I realized this bug surfaces as crashes in
content::NavigationEntryImpl::CloneAndReplace, which is
https://crbug.com/584739.  So this should be a useful crash fix after all!

[alexmos, 2016/03/30 16:50:41]

Nice!

 
   // Success is not crashing, and not navigating.
   EXPECT_EQ(nullptr,
             new_shell->web_contents()->GetController().GetLastCommittedEntry());
 }
 
 namespace {
 
 class FrameNavigateParamsCapturer : public WebContentsObserver {
  public:
@@ skipping 2988 matching lines @@
   observer.Wait();
 
   EXPECT_EQ(3, controller.GetEntryCount());
   EXPECT_EQ(3, RendererHistoryLength(shell()));
   EXPECT_EQ(0, controller.GetLastCommittedEntryIndex());
 
   EXPECT_EQ(frame_url_1, frame->current_url());
 }
 
 }  // namespace content