Issue 1683543002: sknx refactoring

mtklein_C

Description was changed from ========== sknx refactoring - trim apis BUG=skia: ========== to ========== sknx ...

4 years, 10 months ago (2016-02-09 01:53:25 UTC) #1

mtklein_C

Description was changed from ========== sknx refactoring - trim apis BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1683543002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot ========== ...

4 years, 10 months ago (2016-02-09 02:55:39 UTC) #2

mtklein_C

Description was changed from ========== sknx refactoring - trim unused types - expand apis a ...

4 years, 10 months ago (2016-02-09 02:55:59 UTC) #3

mtklein_C

Description was changed from ========== sknx refactoring - trim unused types (Sk4i, Sk2d) and apis ...

4 years, 10 months ago (2016-02-09 02:56:29 UTC) #4

mtklein_C

Description was changed from ========== sknx refactoring - trim unused specializations (Sk4i, Sk2d) and apis ...

4 years, 10 months ago (2016-02-09 03:03:28 UTC) #5

mtklein_C

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

4 years, 10 months ago (2016-02-09 03:08:52 UTC) #6

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683543002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683543002/100001

4 years, 10 months ago (2016-02-09 03:08:57 UTC) #7

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 10 months ago (2016-02-09 03:09:59 UTC) #8

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/5953) Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on ...

4 years, 10 months ago (2016-02-09 03:09:59 UTC) #9

mtklein_C

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

4 years, 10 months ago (2016-02-09 03:14:34 UTC) #10

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683543002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683543002/120001

4 years, 10 months ago (2016-02-09 03:14:38 UTC) #11

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 10 months ago (2016-02-09 03:15:32 UTC) #12

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/5954)

4 years, 10 months ago (2016-02-09 03:15:32 UTC) #13

mtklein_C

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

4 years, 10 months ago (2016-02-09 03:17:19 UTC) #14

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683543002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683543002/140001

4 years, 10 months ago (2016-02-09 03:17:28 UTC) #15

mtklein_C

Description was changed from ========== sknx refactoring - trim unused specializations (Sk4i, Sk2d) and apis ...

4 years, 10 months ago (2016-02-09 03:18:38 UTC) #16

Description was changed from

==========
sknx refactoring

  - trim unused specializations (Sk4i, Sk2d) and apis (SkNx_dup)
  - expand apis a little
    * v[0] == v.kth<0>()
    * SkNx_shuffle can now slice down to smaller types, e.g. Sk4f -> Sk2f 
  - remove anonymous namespace

I believe it's safe to remove the anonymous namespace right now.
We're worried about violating the One Definition Rule; the anonymous namespace
protected us from that.

In Release builds, this is mostly moot, as everything tends to inline
completely.
In Debug builds, violating the ODR is at worst an inconvenience, time spent
trying to figure out why the bot is broken.

Now that we're building with SSE2/NEON everywhere, very few bots have even a
chance about getting confused by two definitions of the same type or function. 
Where we do compile variants depending on, e.g., SSSE3, we do so in static
inline functions.  These are not subject to the ODR.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
sknx refactoring

  - trim unused specializations (Sk4i, Sk2d) and apis (SkNx_dup)
  - expand apis a little
    * v[0] == v.kth<0>()
    * SkNx_shuffle can now convert to different-sized vectors, e.g. Sk2f <->
Sk4f
  - remove anonymous namespace

I believe it's safe to remove the anonymous namespace right now.
We're worried about violating the One Definition Rule; the anonymous namespace
protected us from that.

In Release builds, this is mostly moot, as everything tends to inline
completely.
In Debug builds, violating the ODR is at worst an inconvenience, time spent
trying to figure out why the bot is broken.

Now that we're building with SSE2/NEON everywhere, very few bots have even a
chance about getting confused by two definitions of the same type or function. 
Where we do compile variants depending on, e.g., SSSE3, we do so in static
inline functions.  These are not subject to the ODR.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

mtklein_C

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

4 years, 10 months ago (2016-02-09 03:23:59 UTC) #17

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683543002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683543002/160001

4 years, 10 months ago (2016-02-09 03:24:08 UTC) #18

mtklein_C

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

4 years, 10 months ago (2016-02-09 03:28:35 UTC) #19

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683543002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683543002/180001

4 years, 10 months ago (2016-02-09 03:28:38 UTC) #20

mtklein_C

Description was changed from ========== sknx refactoring - trim unused specializations (Sk4i, Sk2d) and apis ...

4 years, 10 months ago (2016-02-09 03:30:09 UTC) #21

Description was changed from

==========
sknx refactoring

  - trim unused specializations (Sk4i, Sk2d) and apis (SkNx_dup)
  - expand apis a little
    * v[0] == v.kth<0>()
    * SkNx_shuffle can now convert to different-sized vectors, e.g. Sk2f <->
Sk4f
  - remove anonymous namespace

I believe it's safe to remove the anonymous namespace right now.
We're worried about violating the One Definition Rule; the anonymous namespace
protected us from that.

In Release builds, this is mostly moot, as everything tends to inline
completely.
In Debug builds, violating the ODR is at worst an inconvenience, time spent
trying to figure out why the bot is broken.

Now that we're building with SSE2/NEON everywhere, very few bots have even a
chance about getting confused by two definitions of the same type or function. 
Where we do compile variants depending on, e.g., SSSE3, we do so in static
inline functions.  These are not subject to the ODR.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
sknx refactoring

  - trim unused specializations (Sk4i, Sk2d) and apis (SkNx_dup)
  - expand apis a little
    * v[0] == v.kth<0>()
    * SkNx_shuffle can now convert to different-sized vectors, e.g. Sk2f <->
Sk4f
  - remove anonymous namespace

I believe it's safe to remove the anonymous namespace right now.
We're worried about violating the One Definition Rule; the anonymous namespace
protected us from that.

In Release builds, this is mostly moot, as everything tends to inline
completely.
In Debug builds, violating the ODR is at worst an inconvenience, time spent
trying to figure out why the bot is broken.

Now that we're building with SSE2/NEON everywhere, very few bots have even a
chance about getting confused by two definitions of the same type or function. 
Where we do compile variants depending on, e.g., SSSE3, we do so in static
inline functions.  These are not subject to the ODR.

I plan to follow up with a tedious .kth<...>() -> [...] auto-replace.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

mtklein_C

mtklein@chromium.org changed reviewers: + herb@google.com

4 years, 10 months ago (2016-02-09 03:36:59 UTC) #22

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 10 months ago (2016-02-09 03:51:01 UTC) #24

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

4 years, 10 months ago (2016-02-09 03:51:01 UTC) #25

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683543002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683543002/180001

4 years, 10 months ago (2016-02-09 18:34:41 UTC) #28

commit-bot: I haz the power

Description was changed from ========== sknx refactoring - trim unused specializations (Sk4i, Sk2d) and apis ...

4 years, 10 months ago (2016-02-09 18:35:30 UTC) #29

Message was sent while issue was closed.

Description was changed from

==========
sknx refactoring

  - trim unused specializations (Sk4i, Sk2d) and apis (SkNx_dup)
  - expand apis a little
    * v[0] == v.kth<0>()
    * SkNx_shuffle can now convert to different-sized vectors, e.g. Sk2f <->
Sk4f
  - remove anonymous namespace

I believe it's safe to remove the anonymous namespace right now.
We're worried about violating the One Definition Rule; the anonymous namespace
protected us from that.

In Release builds, this is mostly moot, as everything tends to inline
completely.
In Debug builds, violating the ODR is at worst an inconvenience, time spent
trying to figure out why the bot is broken.

Now that we're building with SSE2/NEON everywhere, very few bots have even a
chance about getting confused by two definitions of the same type or function. 
Where we do compile variants depending on, e.g., SSSE3, we do so in static
inline functions.  These are not subject to the ODR.

I plan to follow up with a tedious .kth<...>() -> [...] auto-replace.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
sknx refactoring

  - trim unused specializations (Sk4i, Sk2d) and apis (SkNx_dup)
  - expand apis a little
    * v[0] == v.kth<0>()
    * SkNx_shuffle can now convert to different-sized vectors, e.g. Sk2f <->
Sk4f
  - remove anonymous namespace

I believe it's safe to remove the anonymous namespace right now.
We're worried about violating the One Definition Rule; the anonymous namespace
protected us from that.

In Release builds, this is mostly moot, as everything tends to inline
completely.
In Debug builds, violating the ODR is at worst an inconvenience, time spent
trying to figure out why the bot is broken.

Now that we're building with SSE2/NEON everywhere, very few bots have even a
chance about getting confused by two definitions of the same type or function. 
Where we do compile variants depending on, e.g., SSSE3, we do so in static
inline functions.  These are not subject to the ODR.

I plan to follow up with a tedious .kth<...>() -> [...] auto-replace.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed:
https://skia.googlesource.com/skia/+/e4c0beed744d09dae4757c1893d8caa64ee09cd2
==========

commit-bot: I haz the power

4 years, 10 months ago (2016-02-09 18:35:31 UTC) #30

Message was sent while issue was closed.

Committed patchset #10 (id:180001) as
https://skia.googlesource.com/skia/+/e4c0beed744d09dae4757c1893d8caa64ee09cd2

Message was sent while issue was closed.

Patchset #11 (id:200001) has been deleted

Issue 1683543002: sknx refactoring (Closed)

Description

Patch Set 1 #

Patch Set 2 : simplify more #

Patch Set 3 : ok? #

Patch Set 4 : shuffle test #

Patch Set 5 : explain #

Patch Set 6 : demo more #

Patch Set 7 : pun pun pun #

Patch Set 8 : moar pun #

Patch Set 9 : expand test #

Patch Set 10 : typos #

Messages