Issue 16835007: Update the include paths of message_loop_proxy.h

Issue 16835007: Update the include paths of message_loop_proxy.h (Closed)

Created:
7 years, 6 months ago by tfarina

Modified:
7 years, 6 months ago

Reviewers:
Lei Zhang, jamesr, darin (slow to review), eroman, Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, sanjeevr, sadrul, dcaiafa+watch_chromium.org, sergeyu+watch_chromium.org, tzik+watch_chromium.org, amit, hclam+watch_chromium.org, alexeypa+watch_chromium.org, garykac+watch_chromium.org, wez+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, chromium-apps-reviews_chromium.org, cc-bugs_chromium.org, erikwright+watch_chromium.org, kinuko+watch, mmenke

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update the include paths of message_loop_proxy.h And remove the forwarding file. TBR=darin@chromium.org, eroman@chromium.org, thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207618

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -18 lines)			Patch
D	base/message_loop_proxy.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	cc/trees/proxy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/local_discovery/service_discovery_client_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/media_galleries/fileapi/media_file_validator_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/media_galleries/fileapi/native_media_file_util_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/media_galleries/fileapi/picasa/picasa_file_util_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/dns/mdns_client_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/chromoting_host_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tfarina

TBRing... Darin base/ James cc/ Lei chrome/ Eric net/ Wez remoting/

7 years, 6 months ago (2013-06-20 22:22:19 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/16835007/1

7 years, 6 months ago (2013-06-20 22:23:28 UTC) #2

darin (slow to review)

LGTM On Jun 20, 2013 3:22 PM, <tfarina@chromium.org> wrote: > Reviewers: darin, eroman, jamesr, Lei ...

7 years, 6 months ago (2013-06-20 22:39:31 UTC) #5

LGTM
On Jun 20, 2013 3:22 PM, <tfarina@chromium.org> wrote:

> Reviewers: darin, eroman, jamesr, Lei Zhang, Wez,
>
> Message:
> TBRing...
>
> Darin base/
> James cc/
> Lei chrome/
> Eric net/
> Wez remoting/
>
> Description:
> Update the include paths of message_loop_proxy.h
>
> And remove the forwarding file.
>
> TBR=darin@chromium.org,jamesr@**chromium.org <jamesr@chromium.org>,
> thestig@chromium.**org <thestig@chromium.org>,eroman@chromium.org,wez@**
> chromium.org <wez@chromium.org>
>
> Please review this at
https://codereview.chromium.**org/16835007/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   D base/message_loop_proxy.h
>   M cc/trees/proxy.cc
>   M chrome/browser/extensions/api/**system_info_display/display_**
> info_provider_chromeos.cc
>   M chrome/browser/local_**discovery/service_discovery_**client_impl.cc
>   M chrome/browser/media_**galleries/fileapi/media_file_**
> validator_unittest.cc
>   M chrome/browser/media_**galleries/fileapi/native_**
> media_file_util_unittest.cc
>   M chrome/browser/media_**galleries/fileapi/picasa/**
> picasa_file_util_unittest.cc
>   M net/dns/mdns_client_impl.cc
>   M remoting/host/chromoting_host_**unittest.cc
>
>
> Index: base/message_loop_proxy.h
> diff --git a/base/message_loop_proxy.h b/base/message_loop_proxy.h
> deleted file mode 100644
> index d8a3641722d36c7a67c3a16473d60a**da5eed329f..**
> 000000000000000000000000000000**0000000000
> --- a/base/message_loop_proxy.h
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -// Copyright (c) 2013 The Chromium Authors. All rights reserved.
> -// Use of this source code is governed by a BSD-style license that can be
> -// found in the LICENSE file.
> -
> -// TODO(brettw) remove this forwarding file when all users reference the
> new
> -// location.
> -#include "base/message_loop/message_**loop_proxy.h"
> Index: cc/trees/proxy.cc
> diff --git a/cc/trees/proxy.cc b/cc/trees/proxy.cc
> index 55a58af445ec783f20621827878632**a35fd1ad91..**
> c8dacafb234bad7a7cd5561d435cfa**2669abce13 100644
> --- a/cc/trees/proxy.cc
> +++ b/cc/trees/proxy.cc
> @@ -4,7 +4,7 @@
>
>  #include "cc/trees/proxy.h"
>
> -#include "base/message_loop_proxy.h"
> +#include "base/message_loop/message_**loop_proxy.h"
>  #include "base/single_thread_task_**runner.h"
>
>  namespace cc {
> Index: chrome/browser/extensions/api/**system_info_display/display_**
> info_provider_chromeos.cc
> diff --git a/chrome/browser/extensions/**api/system_info_display/**
> display_info_provider_**chromeos.cc b/chrome/browser/extensions/**
> api/system_info_display/**display_info_provider_**chromeos.cc
> index 5fb380bc0b029f1a388798dab0adc6**4b07e6bf7a..**
> 7ce7621ec7a6a09b968ac9336a32be**e44f12f3db 100644
> --- a/chrome/browser/extensions/**api/system_info_display/**
> display_info_provider_**chromeos.cc
> +++ b/chrome/browser/extensions/**api/system_info_display/**
> display_info_provider_**chromeos.cc
> @@ -7,7 +7,7 @@
>  #include "ash/display/display_**controller.h"
>  #include "ash/display/display_manager.**h"
>  #include "ash/shell.h"
> -#include "base/message_loop_proxy.h"
> +#include "base/message_loop/message_**loop_proxy.h"
>  #include "base/strings/string_number_**conversions.h"
>  #include "content/public/browser/**browser_thread.h"
>  #include "ui/gfx/display.h"
> Index: chrome/browser/local_**discovery/service_discovery_**client_impl.cc
> diff --git
a/chrome/browser/local_**discovery/service_discovery_**client_impl.cc
> b/chrome/browser/local_**discovery/service_discovery_**client_impl.cc
> index 7a2484e3ba5d0eda4084188941fa32**16d85fda1d..**
> a3bb77e59bed24b2f8bf6375d25fa9**ea9e2c8337 100644
> --- a/chrome/browser/local_**discovery/service_discovery_**client_impl.cc
> +++ b/chrome/browser/local_**discovery/service_discovery_**client_impl.cc
> @@ -6,7 +6,7 @@
>
>  #include "base/logging.h"
>  #include "base/memory/singleton.h"
> -#include "base/message_loop_proxy.h"
> +#include "base/message_loop/message_**loop_proxy.h"
>  #include "base/stl_util.h"
>  #include "chrome/browser/local_**discovery/service_discovery_**
> client_impl.h"
>  #include "net/dns/dns_protocol.h"
> Index: chrome/browser/media_**galleries/fileapi/media_file_**
> validator_unittest.cc
> diff --git
a/chrome/browser/media_**galleries/fileapi/media_file_**validator_unittest.cc
> b/chrome/browser/media_**galleries/fileapi/media_file_**
> validator_unittest.cc
> index e23e5b78de8df722ea251ea3183b5d**4e887da4d0..**
> 79d030f096991cc9977d4f5ccccc43**6ecf1be8e6 100644
> --- a/chrome/browser/media_**galleries/fileapi/media_file_**
> validator_unittest.cc
> +++ b/chrome/browser/media_**galleries/fileapi/media_file_**
> validator_unittest.cc
> @@ -7,8 +7,8 @@
>  #include "base/file_util.h"
>  #include "base/files/file_path.h"
>  #include "base/files/scoped_temp_dir.h"
> -#include "base/message_loop.h"
> -#include "base/message_loop_proxy.h"
> +#include "base/message_loop/message_**loop.h"
> +#include "base/message_loop/message_**loop_proxy.h"
>  #include "chrome/browser/media_**galleries/fileapi/media_file_**
> system_mount_point_provider.h"
>  #include "chrome/test/base/in_process_**browser_test.h"
>  #include "content/public/test/browser_**test.h"
> Index: chrome/browser/media_**galleries/fileapi/native_**
> media_file_util_unittest.cc
> diff --git
a/chrome/browser/media_**galleries/fileapi/native_**media_file_util_unittest.cc
> b/chrome/browser/media_**galleries/fileapi/native_**
> media_file_util_unittest.cc
> index 6fdd7cbec9d47a09794d7bd5f88f75**dea4d8c677..**
> 6b475e7e18ef84e1cfd2e71c09af42**9d61961378 100644
> --- a/chrome/browser/media_**galleries/fileapi/native_**
> media_file_util_unittest.cc
> +++ b/chrome/browser/media_**galleries/fileapi/native_**
> media_file_util_unittest.cc
> @@ -9,8 +9,8 @@
>  #include "base/file_util.h"
>  #include "base/files/scoped_temp_dir.h"
>  #include "base/format_macros.h"
> -#include "base/message_loop.h"
> -#include "base/message_loop_proxy.h"
> +#include "base/message_loop/message_**loop.h"
> +#include "base/message_loop/message_**loop_proxy.h"
>  #include "base/strings/stringprintf.h"
>  #include "base/time.h"
>  #include "chrome/browser/media_**galleries/fileapi/media_file_**
> system_mount_point_provider.h"
> Index: chrome/browser/media_**galleries/fileapi/picasa/**
> picasa_file_util_unittest.cc
> diff --git
a/chrome/browser/media_**galleries/fileapi/picasa/**picasa_file_util_unittest.cc
> b/chrome/browser/media_**galleries/fileapi/picasa/**
> picasa_file_util_unittest.cc
> index fd7a29b75c93576586e61e09af9e82**1ff0a05031..**
> 521479692a10dce2e435f681243dc9**e7e57e3549 100644
> --- a/chrome/browser/media_**galleries/fileapi/picasa/**
> picasa_file_util_unittest.cc
> +++ b/chrome/browser/media_**galleries/fileapi/picasa/**
> picasa_file_util_unittest.cc
> @@ -8,8 +8,8 @@
>  #include "base/file_util.h"
>  #include "base/files/scoped_temp_dir.h"
>  #include "base/memory/scoped_vector.h"
> -#include "base/message_loop.h"
> -#include "base/message_loop_proxy.h"
> +#include "base/message_loop/message_**loop.h"
> +#include "base/message_loop/message_**loop_proxy.h"
>  #include "base/run_loop.h"
>  #include "base/strings/stringprintf.h"
>  #include "base/time.h"
> Index: net/dns/mdns_client_impl.cc
> diff --git a/net/dns/mdns_client_impl.cc b/net/dns/mdns_client_impl.cc
> index 4aac454cc01d2e45b52491411b6c36**18ce4d94b3..**
> 27a97c4d57079ba680222ab6cbd0df**698b88ddf5 100644
> --- a/net/dns/mdns_client_impl.cc
> +++ b/net/dns/mdns_client_impl.cc
> @@ -5,7 +5,7 @@
>  #include "net/dns/mdns_client_impl.h"
>
>  #include "base/bind.h"
> -#include "base/message_loop_proxy.h"
> +#include "base/message_loop/message_**loop_proxy.h"
>  #include "base/stl_util.h"
>  #include "base/time/default_clock.h"
>  #include "net/base/dns_util.h"
> Index: remoting/host/chromoting_host_**unittest.cc
> diff --git a/remoting/host/chromoting_**host_unittest.cc
> b/remoting/host/chromoting_**host_unittest.cc
> index 0857e05f00e3a7d507e8ae52afa5a8**589cd88db1..**
> 1410371a9bc8b5049461e024669702**0ac5377808 100644
> --- a/remoting/host/chromoting_**host_unittest.cc
> +++ b/remoting/host/chromoting_**host_unittest.cc
> @@ -6,7 +6,6 @@
>  #include "base/bind_helpers.h"
>  #include "base/memory/scoped_ptr.h"
>  #include "base/message_loop/message_**loop_proxy.h"
> -#include "base/message_loop_proxy.h"
>  #include "remoting/base/auto_thread_**task_runner.h"
>  #include "remoting/host/audio_capturer.**h"
>  #include "remoting/host/chromoting_**host.h"
>
>
>

tfarina

7 years, 6 months ago (2013-06-20 22:49:51 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 manually as r207618 (presubmit successful).

Expand Messages | Collapse Messages