Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1683343005: change static method types to not have the class type parameters (Closed)

Created:
4 years, 10 months ago by Jennifer Messerly
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

change static method types to not have the class type parameters R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/d15416bdca71638c512574a5a2860ef8b57b653d

Patch Set 1 #

Patch Set 2 : sort #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -19 lines) Patch
M pkg/analyzer/lib/src/dart/element/type.dart View 1 chunk +10 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 2 4 chunks +64 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Jennifer Messerly
Hey, this is the FunctionType issue we were talking about. BTW, not sure if there's ...
4 years, 10 months ago (2016-02-11 23:32:33 UTC) #2
vsm
DBC https://codereview.chromium.org/1683343005/diff/20001/pkg/analyzer/test/generated/resolver_test.dart File pkg/analyzer/test/generated/resolver_test.dart (right): https://codereview.chromium.org/1683343005/diff/20001/pkg/analyzer/test/generated/resolver_test.dart#newcode10247 pkg/analyzer/test/generated/resolver_test.dart:10247: reason: 'this tatic method is not generic'); s/tatic/static/
4 years, 10 months ago (2016-02-11 23:38:27 UTC) #4
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-11 23:50:11 UTC) #5
Jennifer Messerly
4 years, 10 months ago (2016-02-12 17:39:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
d15416bdca71638c512574a5a2860ef8b57b653d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698