Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 1683273002: Disable several AutofillInteractive tests on ChromeOS (Closed)

Created:
4 years, 10 months ago by iclelland
Modified:
4 years, 10 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable several AutofillInteractive tests on ChromeOS Several tests have been timing out more or less consistently on ChromeOS. Occasionally, they time out four times in a row, and escalate to an actual failure in the builder. This patch disables the most recent offenders: AutofillInteractiveTest.OnInputAfterAutofill AutofillInteractiveTest.DisableAutocompleteWhileFilling AutofillInteractiveTest.InputFiresBeforeChange AutofillInteractiveTest.NoAutofillForReadOnlyFields AutofillInteractiveTest.AutofillFormWithRepeatedField AutofillInteractiveTest.BasicFormFill TBR=mathp@chromium.org BUG=585885 Committed: https://crrev.com/380b367b6e8fb305b94ab12b9ed263053e1e7790 Cr-Commit-Position: refs/heads/master@{#374715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -7 lines) Patch
M chrome/browser/autofill/autofill_interactive_uitest.cc View 6 chunks +41 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683273002/1
4 years, 10 months ago (2016-02-10 19:54:32 UTC) #2
Mathieu
lgtm
4 years, 10 months ago (2016-02-10 20:35:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 20:47:52 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:30:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/380b367b6e8fb305b94ab12b9ed263053e1e7790
Cr-Commit-Position: refs/heads/master@{#374715}

Powered by Google App Engine
This is Rietveld 408576698