Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: tests/lib/async/timer_test.dart

Issue 1683233003: Use Stopwatch instead of DateTime to measure elapsed time in tests. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tests/lib/async/timer_repeat_test.dart ('k') | tests/standalone/io/sleep_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library timer_test; 5 library timer_test;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'package:unittest/unittest.dart'; 8 import 'package:unittest/unittest.dart';
9 9
10 const int STARTTIMEOUT = 1050; 10 const int STARTTIMEOUT = 1050;
11 const int DECREASE = 200; 11 const int DECREASE = 200;
12 const int ITERATIONS = 5; 12 const int ITERATIONS = 5;
13 13
14 int startTime; 14 Stopwatch stopwatch = new Stopwatch();
15 int timeout; 15 int timeout;
16 int iteration; 16 int iteration;
17 17
18 // Some browsers (Firefox and IE so far) can trigger too early. Add a safety 18 // Some browsers (Firefox and IE so far) can trigger too early. Add a safety
19 // margin. We use identical(1, 1.0) as an easy way to know if the test is 19 // margin. We use identical(1, 1.0) as an easy way to know if the test is
20 // compiled by dart2js. 20 // compiled by dart2js.
21 int get safetyMargin => identical(1, 1.0) ? 100 : 0; 21 int get safetyMargin => identical(1, 1.0) ? 100 : 0;
22 22
23 void timeoutHandler() { 23 void timeoutHandler() {
24 int endTime = (new DateTime.now()).millisecondsSinceEpoch; 24 expect(stopwatch.elapsedMilliseconds + safetyMargin,
25 expect(endTime - startTime + safetyMargin, greaterThanOrEqualTo(timeout)); 25 greaterThanOrEqualTo(timeout));
26 if (iteration < ITERATIONS) { 26 if (iteration < ITERATIONS) {
27 iteration++; 27 iteration++;
28 timeout = timeout - DECREASE; 28 timeout = timeout - DECREASE;
29 Duration duration = new Duration(milliseconds: timeout); 29 Duration duration = new Duration(milliseconds: timeout);
30 startTime = (new DateTime.now()).millisecondsSinceEpoch; 30 stopwatch.reset();
31 new Timer(duration, expectAsync(timeoutHandler)); 31 new Timer(duration, expectAsync(timeoutHandler));
32 } 32 }
33 } 33 }
34 34
35 main() { 35 main() {
36 test("timeout test", () { 36 test("timeout test", () {
37 iteration = 0; 37 iteration = 0;
38 timeout = STARTTIMEOUT; 38 timeout = STARTTIMEOUT;
39 Duration duration = new Duration(milliseconds: timeout); 39 Duration duration = new Duration(milliseconds: timeout);
40 startTime = (new DateTime.now()).millisecondsSinceEpoch; 40 stopwatch.start();
41 new Timer(duration, expectAsync(timeoutHandler)); 41 new Timer(duration, expectAsync(timeoutHandler));
42 }); 42 });
43 } 43 }
OLDNEW
« no previous file with comments | « tests/lib/async/timer_repeat_test.dart ('k') | tests/standalone/io/sleep_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698