Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 1683233002: Documentation for accessing the different repositories of SKPs (Closed)

Created:
4 years, 10 months ago by rmistry
Modified:
4 years, 10 months ago
Reviewers:
hcm, jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 : Initial upload #

Patch Set 2 : Rename file #

Patch Set 3 : Complete #

Total comments: 2

Patch Set 4 : Address feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -0 lines) Patch
A site/dev/testing/skps.md View 1 2 3 1 chunk +67 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
rmistry
4 years, 10 months ago (2016-02-10 19:34:13 UTC) #3
jcgregorio
lgtm
4 years, 10 months ago (2016-02-10 19:54:58 UTC) #4
hcm
One minor readability comment below. I was also wondering if we should add a sentence ...
4 years, 10 months ago (2016-02-10 19:55:12 UTC) #5
rmistry
https://codereview.chromium.org/1683233002/diff/160001/site/dev/testing/skps.md File site/dev/testing/skps.md (right): https://codereview.chromium.org/1683233002/diff/160001/site/dev/testing/skps.md#newcode47 site/dev/testing/skps.md:47: * Request access to the gs://chrome-partner-telemetry bucket by emailing ...
4 years, 10 months ago (2016-02-10 20:46:15 UTC) #12
hcm
On 2016/02/10 20:46:15, rmistry wrote: > https://codereview.chromium.org/1683233002/diff/160001/site/dev/testing/skps.md > File site/dev/testing/skps.md (right): > > https://codereview.chromium.org/1683233002/diff/160001/site/dev/testing/skps.md#newcode47 > ...
4 years, 10 months ago (2016-02-10 20:52:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683233002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683233002/180001
4 years, 10 months ago (2016-02-10 20:54:33 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 20:55:12 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:180001) as
https://skia.googlesource.com/skia/+/d31588523c531353a5139739cc81ec6cf91eaa96

Powered by Google App Engine
This is Rietveld 408576698