Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h

Issue 1683213002: Clean up drawing buffer code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h
diff --git a/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h b/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h
index c42faa8fa3ed28edd72aca2e2666d749b3e2b9df..5727b58b88ef8db31131adf26720ea6764cf47f1 100644
--- a/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h
+++ b/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h
@@ -171,7 +171,6 @@ protected: // For unittests
SupportedExtensions();
bool multisample;
- bool packedDepthStencil;
bool depth24;
bool discardFramebuffer;
};
@@ -305,7 +304,6 @@ private:
IntSize m_size;
WebGraphicsContext3D::Attributes m_requestedAttributes;
bool m_multisampleExtensionSupported;
- bool m_packedDepthStencilExtensionSupported;
bool m_depth24ExtensionSupported;
bool m_discardFramebufferSupported;
Platform3DObject m_fbo;
@@ -319,12 +317,10 @@ private:
OwnPtr<Closure> m_newMailboxCallback;
- // This is used when we have OES_packed_depth_stencil.
Platform3DObject m_depthStencilBuffer;
- // These are used when we don't.
+ // This is used when we only request depth and Depth24 extension is available.
Ken Russell (switch to Gerrit) 2016/02/10 18:04:31 "Depth24 extension" -> "the OES_depth24 extension"
Zhenyao Mo 2016/02/10 18:21:18 Done.
Platform3DObject m_depthBuffer;
- Platform3DObject m_stencilBuffer;
// For multisampling.
Platform3DObject m_multisampleFBO;
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698