Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1683213002: Clean up drawing buffer code. (Closed)

Created:
4 years, 10 months ago by Zhenyao Mo
Modified:
4 years, 10 months ago
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, vmpstr+blinkwatch_chromium.org, dshwang, jbroman, Justin Novosad, danakj+watch_chromium.org, Rik, f(malita), blink-reviews, piman+watch_chromium.org, kinuko+watch, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up drawing buffer code. Since we no longer support the path where packed_depth_stencil isn't supported. BUG=570453 TEST=build, no behavior change R=kbr@chromium.org Committed: https://crrev.com/d89c4e01716053d7bd4642f42c8d4a1ecefcaf92 Cr-Commit-Position: refs/heads/master@{#374711}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -39 lines) Patch
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h View 1 3 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 7 chunks +2 lines, -34 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Zhenyao Mo
kbr: PTAL
4 years, 10 months ago (2016-02-10 17:59:47 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683213002/1
4 years, 10 months ago (2016-02-10 18:00:07 UTC) #3
Ken Russell (switch to Gerrit)
This is great. LGTM. One minor comment correction. https://codereview.chromium.org/1683213002/diff/1/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h File third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h (right): https://codereview.chromium.org/1683213002/diff/1/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h#newcode322 third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h:322: // ...
4 years, 10 months ago (2016-02-10 18:04:31 UTC) #4
Zhenyao Mo
https://codereview.chromium.org/1683213002/diff/1/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h File third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h (right): https://codereview.chromium.org/1683213002/diff/1/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h#newcode322 third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h:322: // This is used when we only request depth ...
4 years, 10 months ago (2016-02-10 18:21:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683213002/20001
4 years, 10 months ago (2016-02-10 18:23:50 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-10 20:24:04 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:30:45 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d89c4e01716053d7bd4642f42c8d4a1ecefcaf92
Cr-Commit-Position: refs/heads/master@{#374711}

Powered by Google App Engine
This is Rietveld 408576698