Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1683203002: fixes #25641, error message when type arguments do not match (Closed)

Created:
4 years, 10 months ago by Jennifer Messerly
Modified:
4 years, 10 months ago
Reviewers:
Leaf, Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fixes #25641, error message when type arguments do not match R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/6bf029a5c746ee2b5b35c8076f49e9f0c6fde320

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
M pkg/analyzer/lib/src/generated/element_resolver.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 3 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
I know, we could add more test cases, but look at it this way, it's ...
4 years, 10 months ago (2016-02-10 17:53:56 UTC) #2
Bob Nystrom
lgtm
4 years, 10 months ago (2016-02-10 18:45:32 UTC) #3
Jennifer Messerly
4 years, 10 months ago (2016-02-10 22:46:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6bf029a5c746ee2b5b35c8076f49e9f0c6fde320 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698