Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1683173002: Revert of Finally get rid of depot_tools' breakpad. (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Finally get rid of depot_tools' breakpad. (patchset #2 id:20001 of https://codereview.chromium.org/1689633002/ ) Reason for revert: All chromium bots depend on this: ________ running '/usr/bin/python src/build/android/play_services/update.py download' in '/b/build/slave/linux/build' Traceback (most recent call last): File "src/build/android/play_services/update.py", line 29, in <module> import find_depot_tools # pylint: disable=import-error,unused-import File "/b/build/slave/linux/build/src/build/find_depot_tools.py", line 49, in <module> import breakpad ImportError: No module named breakpad https://www.google.com/url?hl=en&q=http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/144739&source=gmail&ust=1455209366639000&usg=AFQjCNH42SEVcJg4J6dX0J9HF0Rcqv81eA Original issue's description: > Finally get rid of depot_tools' breakpad. > > R=maruel@chromium.org > BUG= > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298710 TBR=maruel@chromium.org,tandrii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298712

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -2 lines) Patch
M apply_issue.py View 1 chunk +1 line, -0 lines 0 comments Download
A breakpad.py View 1 chunk +147 lines, -0 lines 0 comments Download
M commit_queue.py View 1 chunk +2 lines, -0 lines 0 comments Download
M drover.py View 3 chunks +3 lines, -2 lines 0 comments Download
M gcl.py View 2 chunks +8 lines, -0 lines 0 comments Download
M gclient.py View 1 chunk +2 lines, -0 lines 0 comments Download
M git_cl.py View 2 chunks +7 lines, -0 lines 0 comments Download
M git_try.py View 1 chunk +2 lines, -0 lines 0 comments Download
A tests/breakpad_unittest.py View 1 chunk +123 lines, -0 lines 0 comments Download
M tests/git_cl_test.py View 2 chunks +6 lines, -0 lines 0 comments Download
M tests/trychange_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M trychange.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Nico
Created Revert of Finally get rid of depot_tools' breakpad.
4 years, 10 months ago (2016-02-10 16:51:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683173002/1
4 years, 10 months ago (2016-02-10 16:51:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=298712
4 years, 10 months ago (2016-02-10 16:51:44 UTC) #4
M-A Ruel
lgtm
4 years, 10 months ago (2016-02-10 16:55:34 UTC) #5
tandrii(chromium)
4 years, 10 months ago (2016-02-10 17:00:21 UTC) #6
Message was sent while issue was closed.
argh, thanks for reverting! More cleanup needed :(

Powered by Google App Engine
This is Rietveld 408576698