Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 1683153002: Allocator cleanup: remove reundant tc_set_new_mode in ProcessMemoryTest (Closed)

Created:
4 years, 10 months ago by Primiano Tucci (use gerrit)
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang, Nico
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allocator cleanup: remove reundant tc_set_new_mode in ProcessMemoryTest Leftover from the previous cleanups. Previously, when base did pretend to not know anything about allocator, tc_set_new_mode was invoked by the content layer (in content_main). But this required this base unittest to mimic the same content behavior. These days, instead, tc_set_new_mode() is called by base's EnableTerminationOnOutOfMemory(). This test is already invoking EnableTerminationOnOutOfMemory() in its initialization, so there is no need to perform a 2nd call to tc_set_new_mode. Also this makes the code in this test conceptually cleaner and smaller. BUG=564618 TEST=base_unittests Committed: https://crrev.com/e9da717d1cd3fd4b41b04456b9e454c5c028cac3 Cr-Commit-Position: refs/heads/master@{#374750}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M base/process/memory_unittest.cc View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Primiano Tucci (use gerrit)
Nico, small cleanup. 12 shy lines in base were trying to avoid the flame-throwing, tsk.
4 years, 10 months ago (2016-02-10 16:00:47 UTC) #3
Primiano Tucci (use gerrit)
On 2016/02/10 16:00:47, Primiano Tucci wrote: > Nico, small cleanup. > 12 shy lines in ...
4 years, 10 months ago (2016-02-10 18:24:56 UTC) #4
Primiano Tucci (use gerrit)
Timezone change, let's see if I'm are luckier with +thestig. PTAL it's a -12 lines ...
4 years, 10 months ago (2016-02-10 22:03:01 UTC) #6
Nico
lgtm
4 years, 10 months ago (2016-02-10 22:04:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683153002/1
4 years, 10 months ago (2016-02-10 22:10:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 22:18:22 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:31:45 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e9da717d1cd3fd4b41b04456b9e454c5c028cac3
Cr-Commit-Position: refs/heads/master@{#374750}

Powered by Google App Engine
This is Rietveld 408576698