Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1683123002: Mention how to convert "copies" from gyp to gn in the cookbook. (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mention how to convert "copies" from gyp to gn in the cookbook. BUG=none Committed: https://crrev.com/bf781415f643cacdb62968ef765f83fa12674ac6 Cr-Commit-Position: refs/heads/master@{#374791}

Patch Set 1 #

Patch Set 2 : NEWLINE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M tools/gn/docs/cookbook.md View 1 2 chunks +31 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Nico
4 years, 10 months ago (2016-02-10 14:50:06 UTC) #2
Nico
+dpranke in case brettw is out today
4 years, 10 months ago (2016-02-10 23:33:00 UTC) #4
Dirk Pranke
lgtm
4 years, 10 months ago (2016-02-10 23:37:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683123002/20001
4 years, 10 months ago (2016-02-10 23:40:17 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-10 23:50:58 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:32:50 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/bf781415f643cacdb62968ef765f83fa12674ac6
Cr-Commit-Position: refs/heads/master@{#374791}

Powered by Google App Engine
This is Rietveld 408576698