chrome/browser/resources/extensions/extension_list.js - Issue 16831012: Fix a bug where an extension's icon was not being properly updated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 16831012: Fix a bug where an extension's icon was not being properly updated. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/extensions/extension_list.js

diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js

index ea232a5732ffcb067914efea014e972abb5034f9..6b9f6d9edff010442384a2d4346f5e9301222fc7 100644

--- a/chrome/browser/resources/extensions/extension_list.js

+++ b/chrome/browser/resources/extensions/extension_list.js

@@ -97,7 +97,8 @@ cr.define('options', function() {

node.classList.add('extension-highlight');

var item = node.querySelector('.extension-list-item');

- item.style.backgroundImage = 'url(' + extension.icon + ')';

+ item.style.backgroundImage = 'url(' + extension.icon + '?' +

+ extension.imageId + ')';

var title = node.querySelector('.extension-title');

title.textContent = extension.name;

« no previous file with comments | « AUTHORS ('k') | chrome/browser/ui/webui/extensions/extension_basic_info.cc » ('j') | no next file with comments »