Perform glReadPixels with PBOs in the gpu, if PBOs are available.

gpu/command_buffer/service/feature_info.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/feature_info.h"
 
 #include <set>
 
 #include "base/command_line.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 99 matching lines @@
       angle_pack_reverse_row_order(false),
       arb_texture_rectangle(false),
       angle_instanced_arrays(false),
       occlusion_query_boolean(false),
       use_arb_occlusion_query2_for_occlusion_query_boolean(false),
       use_arb_occlusion_query_for_occlusion_query_boolean(false),
       native_vertex_array_object(false),
       enable_shader_name_hashing(false),
       enable_samplers(false),
       ext_draw_buffers(false),
-      ext_frag_depth(false) {
+      ext_frag_depth(false),
+      use_async_readpixels(false) {
 }
 
 FeatureInfo::Workarounds::Workarounds() :
 #define GPU_OP(type, name) name(false),
     GPU_DRIVER_BUG_WORKAROUNDS(GPU_OP)
 #undef GPU_OP
     max_texture_size(0),
     max_cube_map_texture_size(0) {
 }
 
@@ skipping 485 matching lines @@
          ++i) {
       validators_.g_l_state.AddValue(i);
     }
   }
 
   if (extensions.Contains("GL_EXT_frag_depth") || gfx::HasDesktopGLFeatures()) {
     AddExtensionString("GL_EXT_frag_depth");
     feature_flags_.ext_frag_depth = true;
   }
 
+  bool ui_gl_fence_works =
+      extensions.Contains("GL_NV_fence") ||
+      extensions.Contains("GL_ARB_sync");
+
+  if (ui_gl_fence_works &&
+      extensions.Contains("GL_ARB_pixel_buffer_object") &&
+      !command_line.HasSwitch(switches::kForceSynchronousGLReadPixels) &&

[piman, 2013/06/26 22:17:08]

You don't need this any more. You have
--gpu-driver-bug-workarounds='disable_async_readpixels'

Also, looking at the origin of this flag (in
content/browser/renderer_host/compositing_iosurface_mac.mm), it sounds like you
need a blacklisting entry on intel drivers on older macs, where PBOs are exposed
but crash - I think you need to add it to
gpu/config/gpu_driver_bug_list_json.cc. zmo@ can probably help you.

[hubbe, 2013/06/28 22:17:49]

Removed the HasSwitch call.
I'm trying to find out if the workaround is strictly needed. We did some
investigating, and it would seem that the code that had a problem didn't
actually check if the driver claimed to support PBOs or now. I need to talk to
alpha (who wrote the workaround) and figure out if that particular mac/driver
combo actually lists PBOs as supported or not.

[hubbe, 2013/06/29 00:13:56]

Talked to alpha, and it seems that the workaround is indeed needed, so I went
ahead and added it. Not sure if anybody around here has a mac like that to test
it on though...

+      !workarounds_.disable_async_readpixels) {
+    feature_flags_.use_async_readpixels = true;
+  }
+
   if (!disallowed_features_.swap_buffer_complete_callback)
     AddExtensionString("GL_CHROMIUM_swapbuffers_complete_callback");
 
   bool is_es3 = false;
   const char* str = reinterpret_cast<const char*>(glGetString(GL_VERSION));
   if (str) {
     std::string lstr(StringToLowerASCII(std::string(str)));
     is_es3 = (lstr.substr(0, 12) == "opengl es 3.");
   }
 
   if (is_es3 || extensions.Contains("GL_ARB_sampler_objects")) {
     feature_flags_.enable_samplers = true;
     // TODO(dsinclair): Add AddExtensionString("GL_CHROMIUM_sampler_objects")
     // when available.
   }
 }
 
 void FeatureInfo::AddExtensionString(const std::string& str) {
   if (extensions_.find(str) == std::string::npos) {
     extensions_ += (extensions_.empty() ? "" : " ") + str;
   }
 }
 
 FeatureInfo::~FeatureInfo() {
 }
 
 }  // namespace gles2
 }  // namespace gpu