Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 1683093002: Revert of Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas. (Closed)

Created:
4 years, 10 months ago by caryclark
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas. (patchset #3 id:40001 of https://codereview.chromium.org/1681643002/ ) Reason for revert: breaks various android builds, e.g. https://android-build.storage.googleapis.com/builds/git_master-skia-linux-bullhead-userdebug/2596406/acb02999d48ace628601452700d4b4f8dcd5ed71b426e6ecdb1c7f5bc5452f7b/logs/build_error.log?Signature=BkLEdMOdi0LelP0v939QECdTZzznSD2dLFIkPu52E7%2BPr5Oj1ktq5nNlxGZn%2F4ZhCKXAw2%2FNHxy27nNJ8lffcgXn7PhQpa82bP%2B8F%2Bbyo9j%2BT%2B3etmOdQFEejJSRsEv2RrVWtKsKYRX%2FuZinrF9yD37jUpSbKNZvmvIbKa4V4IQ%3D&GoogleAccessId=701025073339-mqn0q2nvir9iurm6q5d00tdv7blbgvjr%40developer.gserviceaccount.com&Expires=1455108483 external/skia/bench/../tools/debugger/SkDrawCommand.cpp:602:9: error: use of undeclared identifier 'free' free(data); Original issue's description: > Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas. > SkJSONCanvas and SkJSONRenderer will be deleted once the debug server > has been updated. > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1681643002 > > Committed: https://skia.googlesource.com/skia/+/32fff1ba0c759d97ab78320b7ae46dd7696a4e6e > > Committed: https://skia.googlesource.com/skia/+/46cb6d6b82b0ab71033aef91419e8beae25bb8a4 TBR=jcgregorio@google.com,joshualitt@chromium.org,ethannicholas@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/d116561ddcca3f961b30cd9e485d81b654bc10ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1931 lines) Patch
M gyp/SampleApp.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/debugger.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/debugger/SkDrawCommand.h View 31 chunks +5 lines, -86 lines 0 comments Download
M tools/debugger/SkDrawCommand.cpp View 30 chunks +0 lines, -1839 lines 0 comments Download
M tools/debugger/SkObjectParser.cpp View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
caryclark
Created Revert of Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas.
4 years, 10 months ago (2016-02-10 12:33:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683093002/1
4 years, 10 months ago (2016-02-10 12:33:58 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 12:34:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d116561ddcca3f961b30cd9e485d81b654bc10ec

Powered by Google App Engine
This is Rietveld 408576698