Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 1683083002: Revert of [Contextual Search] Re-landing the CL: https://codereview.chromium.org/1669983003/ (Closed)

Created:
4 years, 10 months ago by blundell
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@flaky_test
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Contextual Search] Re-landing the CL: https://codereview.chromium.org/1669983003/ (patchset #3 id:40001 of https://codereview.chromium.org/1685763003/ ) Reason for revert: Test crashes flakily (e.g., https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/24765). I would attach a snippet of output from the crash, but there is no useful output that I can see. Original issue's description: > [Contextual Search] Re-landing the CL: https://codereview.chromium.org/1669983003/ > > Fixes and re-enables > ContextualSearchManagerTest#testChainedSearchLoadsCorrectSearchTerm. > > Sometimes, the test tries to check the search term before > the URL has started loading, which ends up resulting in > failing to match the search term. The empty URL could also > cause a crash when running the test, so this CL fixes the > problem by waiting for the URL to match the search term, > and also checks if the URL is null to prevent crashes. > > BUG=551711 > > Committed: https://crrev.com/9be717a273fb91fc5e2f1217fd42baabd92025fe > Cr-Commit-Position: refs/heads/master@{#374531} TBR=mdjones@chromium.org,pedrosimonetti@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=551711 Committed: https://crrev.com/5c19be8c985db1f4c158ca854252b2dd41b64f3c Cr-Commit-Position: refs/heads/master@{#374642}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -18 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java View 5 chunks +4 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
blundell
Created Revert of [Contextual Search] Re-landing the CL: https://codereview.chromium.org/1669983003/
4 years, 10 months ago (2016-02-10 11:52:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683083002/1
4 years, 10 months ago (2016-02-10 11:52:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 11:53:42 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 11:54:47 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c19be8c985db1f4c158ca854252b2dd41b64f3c
Cr-Commit-Position: refs/heads/master@{#374642}

Powered by Google App Engine
This is Rietveld 408576698