DescriptionRevert of [Contextual Search] Re-landing the CL: https://codereview.chromium.org/1669983003/ (patchset #3 id:40001 of https://codereview.chromium.org/1685763003/ )
Reason for revert:
Test crashes flakily (e.g., https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/24765). I would attach a snippet of output from the crash, but there is no useful output that I can see.
Original issue's description:
> [Contextual Search] Re-landing the CL: https://codereview.chromium.org/1669983003/
>
> Fixes and re-enables
> ContextualSearchManagerTest#testChainedSearchLoadsCorrectSearchTerm.
>
> Sometimes, the test tries to check the search term before
> the URL has started loading, which ends up resulting in
> failing to match the search term. The empty URL could also
> cause a crash when running the test, so this CL fixes the
> problem by waiting for the URL to match the search term,
> and also checks if the URL is null to prevent crashes.
>
> BUG=551711
>
> Committed: https://crrev.com/9be717a273fb91fc5e2f1217fd42baabd92025fe
> Cr-Commit-Position: refs/heads/master@{#374531}
TBR=mdjones@chromium.org,pedrosimonetti@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=551711
Committed: https://crrev.com/5c19be8c985db1f4c158ca854252b2dd41b64f3c
Cr-Commit-Position: refs/heads/master@{#374642}
Patch Set 1 #
Messages
Total messages: 5 (1 generated)
|