Issue 1683063002: Updates from comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1683063002: Updates from comments. (Closed)

Created:
4 years, 10 months ago by Johnni Winther

Modified:
4 years, 9 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -53 lines)			Patch
M	pkg/compiler/lib/src/universe/class_set.dart	View		16 chunks	+59 lines, -43 lines	0 comments	Download
M	pkg/compiler/lib/src/world.dart	View		4 chunks	+8 lines, -4 lines	0 comments	Download
M	tests/compiler/dart2js/class_set_test.dart	View	1 2	3 chunks	+6 lines, -6 lines	0 comments	Download

Total messages: 5 (2 generated)

Johnni Winther

4 years, 9 months ago (2016-03-08 09:37:07 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
7cbfcd69cacaedf03403727cd28696b7717d0635 (presubmit successful).