src/js/symbol.js - Issue 1683043003: Implement symbol @@hasInstance for ES6 instanceof support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/symbol.js

Issue 1683043003: Implement symbol @@hasInstance for ES6 instanceof support. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix broken test. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/js/symbol.js

diff --git a/src/js/symbol.js b/src/js/symbol.js

index 0c87a117ee43de5b3da0eac8e441a3846908f1d5..ae543691c2970ebb110fcd5abfe598ac0e0bcb61 100644

--- a/src/js/symbol.js

+++ b/src/js/symbol.js

@@ -75,8 +75,7 @@ function SymbolKeyFor(symbol) {

// -------------------------------------------------------------------

utils.InstallConstants(GlobalSymbol, [

- // TODO(rossberg): expose when implemented.

- // "hasInstance", hasInstanceSymbol,

+ "hasInstance", hasInstanceSymbol,

"isConcatSpreadable", isConcatSpreadableSymbol,

"iterator", iteratorSymbol,

// TODO(yangguo): expose when implemented.

« no previous file with comments | « src/heap-symbols.h ('k') | test/cctest/cctest.status » ('j') | no next file with comments »