Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 1683043003: Implement symbol @@hasInstance for ES6 instanceof support. (Closed)

Created:
4 years, 10 months ago by mvstanton
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implement symbol @@hasInstance for ES6 instanceof support. BUG= Committed: https://crrev.com/5833e8e8a437cd66405784263ccc45e73470fd42 Cr-Commit-Position: refs/heads/master@{#33870} Committed: https://crrev.com/d69ce04d03d352e6308c0e9cc06055c5f73b0151 Cr-Commit-Position: refs/heads/master@{#33890}

Patch Set 1 #

Patch Set 2 : ARM64 ignition failure. #

Patch Set 3 : Fix broken test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -9 lines) Patch
M src/bootstrapper.cc View 1 2 2 chunks +16 lines, -2 lines 0 comments Download
M src/builtins.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins.cc View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
M src/heap-symbols.h View 2 chunks +1 line, -1 line 0 comments Download
M src/js/symbol.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/cctest.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/es6/hasinstance-symbol.js View 1 chunk +12 lines, -0 lines 0 comments Download
M test/mjsunit/es6/symbols.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/random-bit-correlations.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/test262/test262.status View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (11 generated)
mvstanton
Hi Benedikt, here is the CL we discussed, thx for the look! --Mike
4 years, 10 months ago (2016-02-10 13:24:53 UTC) #2
Benedikt Meurer
Nice. LGTM!
4 years, 10 months ago (2016-02-10 13:27:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683043003/1
4 years, 10 months ago (2016-02-10 13:44:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/15125)
4 years, 10 months ago (2016-02-10 14:05:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683043003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683043003/20001
4 years, 10 months ago (2016-02-10 14:14:11 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-10 14:34:45 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5833e8e8a437cd66405784263ccc45e73470fd42 Cr-Commit-Position: refs/heads/master@{#33870}
4 years, 10 months ago (2016-02-10 14:34:59 UTC) #13
Michael Achenbach
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1686123002/ by machenbach@chromium.org. ...
4 years, 10 months ago (2016-02-10 16:21:12 UTC) #14
mvstanton
Hi Benedikt, The random-bit-correlations test is a useful protection, but there are unfortunate false positives. ...
4 years, 10 months ago (2016-02-11 11:29:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683043003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683043003/40001
4 years, 10 months ago (2016-02-11 11:30:26 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-11 11:58:54 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-11 11:58:59 UTC) #22
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 11:59:33 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d69ce04d03d352e6308c0e9cc06055c5f73b0151
Cr-Commit-Position: refs/heads/master@{#33890}

Powered by Google App Engine
This is Rietveld 408576698