Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1683043002: [turbofan] No need to load the feedback vector on the JS graph level. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] No need to load the feedback vector on the JS graph level. Fix JSLoadGlobal/JSStoreGlobal, JSLoadNamed/JSStoreNamed and JSLoadProperty/JSStoreProperty to take the current function closure instead of the type feedback as input, and load the feedback vector from the closure as required (in JSGenericLowering). There's still JSLoadDynamic left to be done, and then we don't have any machine operators in the initial JS graph left. There'll be more refactoring on the JSGenericLowering in a follow-up CL, which takes care of the current code duplication and also tries to use the more efficient LoadIC/KeyedLoadIC instead of the current LoadICInOptimizedCode/KeyedLoadICInOptimizedCode (and same for store ICs) whenever possible. R=jarin@chromium.org Committed: https://crrev.com/9ee47bbc0964f18460fc9181140181dd6cad62ec Cr-Commit-Position: refs/heads/master@{#33854}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -29 lines) Patch
M src/compiler/ast-graph-builder.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +105 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-10 06:33:50 UTC) #1
Benedikt Meurer
Hey Jaro, First step towards sane JS graph level again. Please take a look. Thanks, ...
4 years, 10 months ago (2016-02-10 06:35:15 UTC) #2
Jarin
lgtm.
4 years, 10 months ago (2016-02-10 06:58:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683043002/1
4 years, 10 months ago (2016-02-10 06:58:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 07:00:44 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 07:01:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ee47bbc0964f18460fc9181140181dd6cad62ec
Cr-Commit-Position: refs/heads/master@{#33854}

Powered by Google App Engine
This is Rietveld 408576698