Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1683033002: Add a checked_cast for size_t to uint32_t conversion. (Closed)

Created:
4 years, 10 months ago by jam
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a checked_cast for size_t to uint32_t conversion. This should never be hit since we don't allocate more than 2 GB, but it's best practice to ensure so. BUG=581409 Committed: https://crrev.com/a3a30cc274921b9124e92ac01a107c11874bda37 Cr-Commit-Position: refs/heads/master@{#374688}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/child/webblobregistry_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
jam
4 years, 10 months ago (2016-02-10 15:41:00 UTC) #2
Tom Sepez
lgtm
4 years, 10 months ago (2016-02-10 17:55:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683033002/1
4 years, 10 months ago (2016-02-10 18:00:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 18:15:14 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 18:16:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3a30cc274921b9124e92ac01a107c11874bda37
Cr-Commit-Position: refs/heads/master@{#374688}

Powered by Google App Engine
This is Rietveld 408576698