Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: base/trace_event/memory_dump_manager.cc

Issue 1683003002: Revert of move --no-sandbox flag from command line for telemetry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sandbox
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/benchmarks/memory_infra.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/memory_dump_manager.cc
diff --git a/base/trace_event/memory_dump_manager.cc b/base/trace_event/memory_dump_manager.cc
index cb59448dda5145d207438590fec18d6cf4013db1..a0f0af372350bc8a37fe34c78f29173a27251edb 100644
--- a/base/trace_event/memory_dump_manager.cc
+++ b/base/trace_event/memory_dump_manager.cc
@@ -419,7 +419,9 @@
if (!mdpinfo->disabled) {
if (mdpinfo->consecutive_failures >= kMaxConsecutiveFailuresCount) {
mdpinfo->disabled = true;
- disabled_reason = "Dump failed multiple times consecutively.";
+ disabled_reason =
+ "Dump failure, possibly related with sandboxing (crbug.com/461788)."
+ " Try --no-sandbox.";
} else if (post_task_failed && mdpinfo->task_runner) {
// Don't disable unbound dump providers. The utility thread is normally
// shutdown when disabling the trace and getting here in this case is
« no previous file with comments | « no previous file | tools/perf/benchmarks/memory_infra.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698