Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Side by Side Diff: tools/perf/benchmarks/memory_infra.py

Issue 1683003002: Revert of move --no-sandbox flag from command line for telemetry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sandbox
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/trace_event/memory_dump_manager.cc ('k') | tools/perf/benchmarks/oortonline.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 6
7 from core import perf_benchmark 7 from core import perf_benchmark
8 8
9 from telemetry import benchmark 9 from telemetry import benchmark
10 from telemetry.timeline import tracing_category_filter 10 from telemetry.timeline import tracing_category_filter
11 from telemetry.web_perf import timeline_based_measurement 11 from telemetry.web_perf import timeline_based_measurement
12 from telemetry.web_perf.metrics import memory_timeline 12 from telemetry.web_perf.metrics import memory_timeline
13 13
14 import page_sets 14 import page_sets
15 15
16 16
17 class _MemoryInfra(perf_benchmark.PerfBenchmark): 17 class _MemoryInfra(perf_benchmark.PerfBenchmark):
18 """Base class for new-generation memory benchmarks based on memory-infra. 18 """Base class for new-generation memory benchmarks based on memory-infra.
19 19
20 This benchmark records data using memory-infra (https://goo.gl/8tGc6O), which 20 This benchmark records data using memory-infra (https://goo.gl/8tGc6O), which
21 is part of chrome tracing, and extracts it using timeline-based measurements. 21 is part of chrome tracing, and extracts it using timeline-based measurements.
22 """ 22 """
23 23
24 def SetExtraBrowserOptions(self, options): 24 def SetExtraBrowserOptions(self, options):
25 options.AppendExtraBrowserArgs([ 25 options.AppendExtraBrowserArgs([
26 # TODO(perezju): Temporary workaround to disable periodic memory dumps. 26 # TODO(perezju): Temporary workaround to disable periodic memory dumps.
27 # See: http://crbug.com/513692 27 # See: http://crbug.com/513692
28 '--enable-memory-benchmarking', 28 '--enable-memory-benchmarking',
29 # TODO(ssid): Remove this flag after fixing http://crbug.com/461788.
30 '--no-sandbox'
29 ]) 31 ])
30 32
31 def CreateTimelineBasedMeasurementOptions(self): 33 def CreateTimelineBasedMeasurementOptions(self):
32 # Enable only memory-infra, to get memory dumps, and blink.console, to get 34 # Enable only memory-infra, to get memory dumps, and blink.console, to get
33 # the timeline markers used for mapping threads to tabs. 35 # the timeline markers used for mapping threads to tabs.
34 trace_memory = tracing_category_filter.TracingCategoryFilter( 36 trace_memory = tracing_category_filter.TracingCategoryFilter(
35 filter_string='-*,blink.console,disabled-by-default-memory-infra') 37 filter_string='-*,blink.console,disabled-by-default-memory-infra')
36 tbm_options = timeline_based_measurement.Options( 38 tbm_options = timeline_based_measurement.Options(
37 overhead_level=trace_memory) 39 overhead_level=trace_memory)
38 tbm_options.config.enable_android_graphics_memtrack = True 40 tbm_options.config.enable_android_graphics_memtrack = True
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 # Tracing.requestMemoryDump DevTools API. See http://crbug.com/540022. 110 # Tracing.requestMemoryDump DevTools API. See http://crbug.com/540022.
109 @benchmark.Disabled('reference') 111 @benchmark.Disabled('reference')
110 class MemoryBenchmarkTop10Mobile(_MemoryInfra): 112 class MemoryBenchmarkTop10Mobile(_MemoryInfra):
111 """Timeline based benchmark for measuring memory on top 10 mobile sites.""" 113 """Timeline based benchmark for measuring memory on top 10 mobile sites."""
112 114
113 page_set = page_sets.MemoryInfraTop10MobilePageSet 115 page_set = page_sets.MemoryInfraTop10MobilePageSet
114 116
115 @classmethod 117 @classmethod
116 def Name(cls): 118 def Name(cls):
117 return 'memory.top_10_mobile' 119 return 'memory.top_10_mobile'
OLDNEW
« no previous file with comments | « base/trace_event/memory_dump_manager.cc ('k') | tools/perf/benchmarks/oortonline.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698