media: Remove VP9 flag, and enable VP9 support by default.

webkit/renderer/media/webmediaplayer_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/renderer/media/webmediaplayer_impl.h"
 
 #include <algorithm>
 #include <limits>
 #include <string>
 #include <vector>
@@ skipping 1060 matching lines @@
   ScopedVector<media::VideoDecoder> video_decoders;
 
   if (gpu_factories_.get()) {
     video_decoders.push_back(new media::GpuVideoDecoder(
         media_loop_, gpu_factories_));
   }
 
   // TODO(phajdan.jr): Remove ifdefs when libvpx with vp9 support is released
   // (http://crbug.com/174287) .
 #if !defined(MEDIA_DISABLE_LIBVPX)
-  if (cmd_line->HasSwitch(switches::kEnableVp9Playback) ||
-      cmd_line->HasSwitch(switches::kEnableVp8AlphaPlayback)) {
-    video_decoders.push_back(new media::VpxVideoDecoder(media_loop_));
-  }
+  video_decoders.push_back(new media::VpxVideoDecoder(media_loop_));

[scherkus (not reviewing), 2013/06/12 20:06:31]

OOC this will still prefer FFmpeg's ffvp8 because you VpxVideoDecoder only does
VP8A?

[Tom Finegan, 2013/06/12 20:35:49]

Right, VpxVideoDecoder only accepts VP8 input when:
- flag is enabled
- output video format is YV12A

FFmpeg still gets all non-alpha VP8.

 #endif  // !defined(MEDIA_DISABLE_LIBVPX)
 
   video_decoders.push_back(new media::FFmpegVideoDecoder(media_loop_));
 
   scoped_ptr<media::VideoRenderer> video_renderer(
       new media::VideoRendererBase(
           media_loop_,
           video_decoders.Pass(),
           set_decryptor_ready_cb,
           base::Bind(&WebMediaPlayerImpl::FrameReady, base::Unretained(this)),
@@ skipping 117 matching lines @@
 
   if (pending_repaint_)
     return;
 
   pending_repaint_ = true;
   main_loop_->PostTask(FROM_HERE, base::Bind(
       &WebMediaPlayerImpl::Repaint, AsWeakPtr()));
 }
 
 }  // namespace webkit_media