Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 16830003: Make security team OWNERS for all IPC *_messages*.h files. (Closed)

Created:
7 years, 6 months ago by palmer
Modified:
7 years, 6 months ago
Reviewers:
parisa, jschuh, Chris Evans
CC:
chromium-reviews, tzik+watch_chromium.org, amit, ahutter, browser-components-watch_chromium.org, Albert Bodenhamer, kinuko+watch, Ilya Sherman, extensions-reviews_chromium.org, benquan, jam, dbeam+watch-autofill_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, dcaiafa+watch_chromium.org, wez+watch_chromium.org, sanjeevr, feature-media-reviews_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, Raman Kakilate, sergeyu+watch_chromium.org, rouslan+autofillwatch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, tfarina, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, alexeypa+watch_chromium.org
Visibility:
Public.

Description

Make security team OWNERS for all IPC *_messages*.h files. We were set for *_messages.h, but there exist other files such as *_messages_android.h and *_messages_internal.h which we should also perform security review on. BUG=247434 R=cevans@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205901

Patch Set 1 #

Total comments: 2

Patch Set 2 : Don't duplicate cevans. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -141 lines) Patch
M android_webview/common/OWNERS View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/importer/OWNERS View 1 1 chunk +7 lines, -8 lines 0 comments Download
M chrome/common/OWNERS View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/common/extensions/OWNERS View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/common/safe_browsing/OWNERS View 1 chunk +7 lines, -7 lines 0 comments Download
M components/autofill/common/OWNERS View 1 chunk +7 lines, -7 lines 0 comments Download
M components/tracing/OWNERS View 1 chunk +7 lines, -7 lines 0 comments Download
M components/visitedlink/common/OWNERS View 1 chunk +7 lines, -7 lines 0 comments Download
M content/child/fileapi/OWNERS View 1 chunk +8 lines, -8 lines 0 comments Download
M content/child/indexed_db/OWNERS View 1 chunk +8 lines, -8 lines 0 comments Download
M content/common/OWNERS View 1 chunk +8 lines, -8 lines 0 comments Download
M content/common/browser_plugin/OWNERS View 1 chunk +7 lines, -7 lines 0 comments Download
M content/common/fileapi/OWNERS View 1 chunk +8 lines, -8 lines 0 comments Download
M content/common/gpu/OWNERS View 1 chunk +8 lines, -8 lines 0 comments Download
M content/common/indexed_db/OWNERS View 1 chunk +8 lines, -8 lines 0 comments Download
M content/common/media/OWNERS View 1 chunk +8 lines, -8 lines 0 comments Download
M ppapi/proxy/OWNERS View 1 chunk +7 lines, -7 lines 0 comments Download
M remoting/host/OWNERS View 1 chunk +7 lines, -7 lines 0 comments Download
M ui/metro_viewer/OWNERS View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
palmer
PTAL. I think the pathname glob syntax is right.
7 years, 6 months ago (2013-06-12 19:29:35 UTC) #1
Chris Evans
On 2013/06/12 19:29:35, Chromium Palmer wrote: > PTAL. I think the pathname glob syntax is ...
7 years, 6 months ago (2013-06-12 19:36:17 UTC) #2
Chris Evans
LGTM. See nit of doom. https://codereview.chromium.org/16830003/diff/1/chrome/browser/importer/OWNERS File chrome/browser/importer/OWNERS (right): https://codereview.chromium.org/16830003/diff/1/chrome/browser/importer/OWNERS#newcode9 chrome/browser/importer/OWNERS:9: per-file *_messages*.h=cevans@chromium.org WTF! Why ...
7 years, 6 months ago (2013-06-12 19:36:36 UTC) #3
palmer
https://codereview.chromium.org/16830003/diff/1/chrome/browser/importer/OWNERS File chrome/browser/importer/OWNERS (right): https://codereview.chromium.org/16830003/diff/1/chrome/browser/importer/OWNERS#newcode9 chrome/browser/importer/OWNERS:9: per-file *_messages*.h=cevans@chromium.org On 2013/06/12 19:36:37, Chris Evans wrote: > ...
7 years, 6 months ago (2013-06-12 19:44:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/16830003/6001
7 years, 6 months ago (2013-06-12 19:47:06 UTC) #5
commit-bot: I haz the power
Failed to apply patch for content/common/gpu/OWNERS: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 6 months ago (2013-06-12 19:47:12 UTC) #6
palmer
7 years, 6 months ago (2013-06-12 19:50:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r205901.

Powered by Google App Engine
This is Rietveld 408576698