Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1682993002: Add about:flags entry for scroll anchoring. (Closed)

Created:
4 years, 10 months ago by skobes
Modified:
4 years, 10 months ago
Reviewers:
Nico, no sievers, ojan
CC:
asvitkine+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add about:flags entry for scroll anchoring. BUG=558575 Committed: https://crrev.com/ba16f4359d0e2fa2ece4f5dc50eb7ac896301b01 Cr-Commit-Position: refs/heads/master@{#374838}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M chrome/app/generated_resources.grd View 1 2 4 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/runtime_features.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_features.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_features.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
skobes
4 years, 10 months ago (2016-02-09 23:55:41 UTC) #2
ojan
lgtm
4 years, 10 months ago (2016-02-10 00:01:24 UTC) #3
skobes
+thakis for chrome/OWNERS +sievers for content/OWNERS
4 years, 10 months ago (2016-02-10 00:09:06 UTC) #5
Nico
lgtm
4 years, 10 months ago (2016-02-10 03:12:58 UTC) #6
no sievers
lgtm
4 years, 10 months ago (2016-02-11 00:37:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682993002/20001
4 years, 10 months ago (2016-02-11 01:03:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/20432) android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, ...
4 years, 10 months ago (2016-02-11 01:08:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682993002/40001
4 years, 10 months ago (2016-02-11 01:17:47 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-11 02:25:39 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:34:06 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ba16f4359d0e2fa2ece4f5dc50eb7ac896301b01
Cr-Commit-Position: refs/heads/master@{#374838}

Powered by Google App Engine
This is Rietveld 408576698