Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: core/src/fpdftext/text_int.h

Issue 1682983002: Make fx_bidi sane. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Stray class decl. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« core/include/fxcrt/fx_bidi.h ('K') | « core/src/fpdftext/fpdf_text_int.cpp ('k') | core/src/fxcrt/fx_bidi.cpp » ('j') | core/src/fxcrt/fx_bidi.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/src/fpdftext/text_int.h
diff --git a/core/src/fpdftext/text_int.h b/core/src/fpdftext/text_int.h
index 93c22736ef07eedf13626fd73880340843e7c730..9131cdb321b19374c9e7c54f7cfe67856cdf85d6 100644
--- a/core/src/fpdftext/text_int.h
+++ b/core/src/fpdftext/text_int.h
@@ -121,8 +121,8 @@ class CPDF_TextPage : public IPDF_TextPage {
void ProcessMarkedContent(PDFTEXT_Obj pObj);
void CheckMarkedContentObject(int32_t& start, int32_t& nCount) const;
void FindPreviousTextObject(void);
- void AddCharInfoByLRDirection(CFX_WideString& str, int i);
- void AddCharInfoByRLDirection(CFX_WideString& str, int i);
+ void AddCharInfoByLRDirection(FX_WCHAR wChar, PAGECHAR_INFO info);
Lei Zhang 2016/02/12 00:46:43 Can you pass |info| by const ref?
Tom Sepez 2016/02/12 17:54:33 Actually, I update it as part of the computations
+ void AddCharInfoByRLDirection(FX_WCHAR wChar, PAGECHAR_INFO info);
int32_t GetTextObjectWritingMode(const CPDF_TextObject* pTextObj);
int32_t FindTextlineFlowDirection();
« core/include/fxcrt/fx_bidi.h ('K') | « core/src/fpdftext/fpdf_text_int.cpp ('k') | core/src/fxcrt/fx_bidi.cpp » ('j') | core/src/fxcrt/fx_bidi.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698