Move miscellaneous properties into CSSPropertyParser

Move miscellaneous properties into CSSPropertyParser

Move the following properties from LegacyCSSPropertyParser into CSSPropertyParser:
- left
- right
- top
- bottom
- image-orientation
- font-size-adjust

Remove parseValidPrimitive since it is not used anymore.

BUG=499780
Committed: https://crrev.com/dcf93f069636d8d4f8ab84b300c7cc2e9bce97ab
Cr-Commit-Position: refs/heads/master@{#375077}

[rwlbuis, 2016-02-10 22:10:40]

Description was changed from

==========
misc WIP

BUG=
==========

to

==========
Move miscellaneous properties into CSSPropertyParser

Move the following properties from LegacyCSSPropertyParser into
CSSPropertyParser:
- left
- right
- top
- bottom
- image-orientation 
- font-size-adjust

Remove createPrimitiveValue since it is not used anymore.

 BUG=499780
==========

[rwlbuis, 2016-02-10 22:11:07]

Description was changed from

==========
Move miscellaneous properties into CSSPropertyParser

Move the following properties from LegacyCSSPropertyParser into
CSSPropertyParser:
- left
- right
- top
- bottom
- image-orientation 
- font-size-adjust

Remove createPrimitiveValue since it is not used anymore.

 BUG=499780
==========

to

==========
Move miscellaneous properties into CSSPropertyParser

Move the following properties from LegacyCSSPropertyParser into
CSSPropertyParser:
- left
- right
- top
- bottom
- image-orientation 
- font-size-adjust

Remove parseValidPrimitive since it is not used anymore.

BUG=499780
==========

[rwlbuis, 2016-02-10 22:12:31]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2016-02-10 22:12:31]

PTAL.

[Timothy Loh, 2016-02-11 02:53:01]

https://codereview.chromium.org/1682963003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/1682963003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:3366: if
(!RuntimeEnabledFeatures::imageOrientationEnabled())
more consistent with other runtime-enabled properties to make this an assert in
the switch statement?

https://codereview.chromium.org/1682963003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:3372: if (angle
&& angle->getIntValue() == 0)
getDoubleValue might be better

https://codereview.chromium.org/1682963003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:3454: return
consumeMarginWidth(m_range, m_context.mode(), UnitlessQuirk::Allow);
These aren't really margins though (I guess they're offsets?)

[rwlbuis, 2016-02-11 20:47:54]

PTAL.

https://codereview.chromium.org/1682963003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/1682963003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:3366: if
(!RuntimeEnabledFeatures::imageOrientationEnabled())
On 2016/02/11 02:53:01, Timothy Loh wrote:
> more consistent with other runtime-enabled properties to make this an assert
in
> the switch statement?

Not sure why I implemented it that way... Just an ASSERT seems to work just fine
indeed.

https://codereview.chromium.org/1682963003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:3372: if (angle
&& angle->getIntValue() == 0)
On 2016/02/11 02:53:01, Timothy Loh wrote:
> getDoubleValue might be better

Done.

https://codereview.chromium.org/1682963003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:3454: return
consumeMarginWidth(m_range, m_context.mode(), UnitlessQuirk::Allow);
On 2016/02/11 02:53:01, Timothy Loh wrote:
> These aren't really margins though (I guess they're offsets?)

True, I hope you like the new method name better, also the Width part in the old
name was a bit questionable, so I removed it.

[Timothy Loh, 2016-02-11 23:29:24]

On 2016/02/11 20:47:54, rwlbuis wrote:
> PTAL.
> 
>
https://codereview.chromium.org/1682963003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):
> 
>
https://codereview.chromium.org/1682963003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:3366: if
> (!RuntimeEnabledFeatures::imageOrientationEnabled())
> On 2016/02/11 02:53:01, Timothy Loh wrote:
> > more consistent with other runtime-enabled properties to make this an assert
> in
> > the switch statement?
> 
> Not sure why I implemented it that way... Just an ASSERT seems to work just
fine
> indeed.
> 
>
https://codereview.chromium.org/1682963003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:3372: if
(angle
> && angle->getIntValue() == 0)
> On 2016/02/11 02:53:01, Timothy Loh wrote:
> > getDoubleValue might be better
> 
> Done.
> 
>
https://codereview.chromium.org/1682963003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:3454: return
> consumeMarginWidth(m_range, m_context.mode(), UnitlessQuirk::Allow);
> On 2016/02/11 02:53:01, Timothy Loh wrote:
> > These aren't really margins though (I guess they're offsets?)
> 
> True, I hope you like the new method name better, also the Width part in the
old
> name was a bit questionable, so I removed it.

lgtm

[rwlbuis, 2016-02-11 23:32:18]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-02-11 23:34:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1682963003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1682963003/60001

[commit-bot: I haz the power, 2016-02-12 01:23:58]

Description was changed from

==========
Move miscellaneous properties into CSSPropertyParser

Move the following properties from LegacyCSSPropertyParser into
CSSPropertyParser:
- left
- right
- top
- bottom
- image-orientation 
- font-size-adjust

Remove parseValidPrimitive since it is not used anymore.

BUG=499780
==========

to

==========
Move miscellaneous properties into CSSPropertyParser

Move the following properties from LegacyCSSPropertyParser into
CSSPropertyParser:
- left
- right
- top
- bottom
- image-orientation 
- font-size-adjust

Remove parseValidPrimitive since it is not used anymore.

BUG=499780
==========

[commit-bot: I haz the power, 2016-02-12 01:23:59]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-16 22:40:32]

Description was changed from

==========
Move miscellaneous properties into CSSPropertyParser

Move the following properties from LegacyCSSPropertyParser into
CSSPropertyParser:
- left
- right
- top
- bottom
- image-orientation 
- font-size-adjust

Remove parseValidPrimitive since it is not used anymore.

BUG=499780
==========

to

==========
Move miscellaneous properties into CSSPropertyParser

Move the following properties from LegacyCSSPropertyParser into
CSSPropertyParser:
- left
- right
- top
- bottom
- image-orientation
- font-size-adjust

Remove parseValidPrimitive since it is not used anymore.

BUG=499780

Committed: https://crrev.com/dcf93f069636d8d4f8ab84b300c7cc2e9bce97ab
Cr-Commit-Position: refs/heads/master@{#375077}
==========

[commit-bot: I haz the power, 2016-02-16 22:40:32]

Patchset 4 (id:??) landed as
https://crrev.com/dcf93f069636d8d4f8ab84b300c7cc2e9bce97ab
Cr-Commit-Position: refs/heads/master@{#375077}