Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 168293002: StorageMonitor: Make StorageInfo a class. (Closed)

Created:
6 years, 10 months ago by Lei Zhang
Modified:
6 years, 10 months ago
CC:
chromium-reviews, Lei Zhang, tommycli, Greg Billock
Visibility:
Public.

Description

StorageMonitor: Make StorageInfo a class. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251957

Patch Set 1 #

Patch Set 2 : rebase after move #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/storage_monitor/media_storage_util.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/storage_info.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Lei Zhang
6 years, 10 months ago (2014-02-15 03:17:19 UTC) #1
vandebo (ex-Chrome)
LGTM
6 years, 10 months ago (2014-02-18 16:13:58 UTC) #2
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 10 months ago (2014-02-18 16:14:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/168293002/1
6 years, 10 months ago (2014-02-18 16:14:10 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 16:14:11 UTC) #5
commit-bot: I haz the power
Failed to apply patch for chrome/browser/storage_monitor/media_storage_util.h: While running patch -p0 --forward --force --no-backup-if-mismatch; can't find ...
6 years, 10 months ago (2014-02-18 16:14:12 UTC) #6
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 10 months ago (2014-02-18 20:27:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/168293002/110001
6 years, 10 months ago (2014-02-18 20:28:54 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 21:30:48 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=265809
6 years, 10 months ago (2014-02-18 21:30:48 UTC) #10
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 10 months ago (2014-02-19 00:25:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/168293002/110001
6 years, 10 months ago (2014-02-19 00:29:24 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 06:01:52 UTC) #13
Message was sent while issue was closed. 
Change committed as 251957

Powered by Google App Engine
This is Rietveld 408576698