Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1682923003: Rename browser side MediaCodec-based decoders (Closed)

Created:
4 years, 10 months ago by Tima Vaisburd
Modified:
4 years, 10 months ago
Reviewers:
qinmin, xhwang, DaleCurtis
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename browser side MediaCodec-based decoders MediaCodecAudioDecoder -> AudioMediaCodecDecoder MediaCodecVideoDecoder -> VideoMediaCodecDecoder This is a prerequisite to https://codereview.chromium.org/1685483002/. We would like to make room for the name MediaCodecAudioDecoder which to use it in the Spitzer pipeline. Besides, the new names better reflect the class hierarchy because the browser side decoders derive from MediaCodecDecoder. BUG=542910 Committed: https://crrev.com/b121df049afb548e5a160530b546337407cb8581 Cr-Commit-Position: refs/heads/master@{#374597}

Patch Set 1 #

Patch Set 2 : Reformatted to make bots happy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -978 lines) Patch
M media/base/android/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
A + media/base/android/audio_media_codec_decoder.h View 4 chunks +7 lines, -7 lines 0 comments Download
A + media/base/android/audio_media_codec_decoder.cc View 1 12 chunks +18 lines, -19 lines 0 comments Download
D media/base/android/media_codec_audio_decoder.h View 1 chunk +0 lines, -103 lines 0 comments Download
D media/base/android/media_codec_audio_decoder.cc View 1 chunk +0 lines, -289 lines 0 comments Download
M media/base/android/media_codec_decoder_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M media/base/android/media_codec_player.h View 2 chunks +4 lines, -4 lines 0 comments Download
M media/base/android/media_codec_player.cc View 1 4 chunks +8 lines, -10 lines 0 comments Download
D media/base/android/media_codec_video_decoder.h View 1 chunk +0 lines, -130 lines 0 comments Download
D media/base/android/media_codec_video_decoder.cc View 1 chunk +0 lines, -360 lines 0 comments Download
A + media/base/android/video_media_codec_decoder.h View 5 chunks +7 lines, -7 lines 0 comments Download
A + media/base/android/video_media_codec_decoder.cc View 1 14 chunks +29 lines, -33 lines 0 comments Download
M media/media.gyp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Tima Vaisburd
We would like to use the name MediaCodecAudioDecoder for the upcoming audio decoder that will ...
4 years, 10 months ago (2016-02-09 23:30:28 UTC) #2
xhwang
lgtm!
4 years, 10 months ago (2016-02-10 00:49:22 UTC) #3
Tima Vaisburd
On 2016/02/10 00:49:22, xhwang wrote: > lgtm! Min, please review as well.
4 years, 10 months ago (2016-02-10 01:02:30 UTC) #4
qinmin
lgtm
4 years, 10 months ago (2016-02-10 01:04:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682923003/1
4 years, 10 months ago (2016-02-10 02:18:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/144571)
4 years, 10 months ago (2016-02-10 02:30:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682923003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682923003/20001
4 years, 10 months ago (2016-02-10 02:43:12 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/91310)
4 years, 10 months ago (2016-02-10 02:58:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682923003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682923003/20001
4 years, 10 months ago (2016-02-10 03:08:17 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-10 04:05:37 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 04:07:47 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b121df049afb548e5a160530b546337407cb8581
Cr-Commit-Position: refs/heads/master@{#374597}

Powered by Google App Engine
This is Rietveld 408576698