Issue 16829002: Notify TraceLog observers outside of the lock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16829002: Notify TraceLog observers outside of the lock (Closed)

Created:
7 years, 6 months ago by James Cook

Modified:
7 years, 6 months ago

Reviewers:
nduca

CC:
chromium-reviews, erikwright+watch_chromium.org, dsinclair

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Notify TraceLog observers outside of the lock This allows observers to call code that uses TRACE_EVENT macros. BUG=none, noticed while developing memory tracing patch TEST=Added to base_unittests TraceEventTestFixture Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206109

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+193 lines, -102 lines)			Patch
M	base/debug/trace_event_impl.h	View	3 chunks	+13 lines, -14 lines	0 comments	Download
M	base/debug/trace_event_impl.cc	View	4 chunks	+106 lines, -79 lines	0 comments	Download
M	base/debug/trace_event_unittest.cc	View	6 chunks	+74 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

James Cook

Nat, PTAL. Dan, just FYI. I had to switch from ObserverList to my own vector ...

7 years, 6 months ago (2013-06-12 18:50:20 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/16829002/1

7 years, 6 months ago (2013-06-12 20:50:10 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=137789

7 years, 6 months ago (2013-06-12 23:11:00 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/16829002/1

7 years, 6 months ago (2013-06-13 15:29:28 UTC) #5

Message was sent while issue was closed.

Change committed as 206109

Expand Messages | Collapse Messages