Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1682873003: [builtins] Speedup Object.keys by adding a fast path for objects without elements, interceptors, ... (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Speedup Object.keys by adding a fast path for objects without elements, interceptors, ... This speeds up the for-of-object benchmark at http://kpdecker.github.io/six-speed/ by >2x. BUG= Committed: https://crrev.com/9ad61e6d81b8ff5c1391fb2b49b510daa15379d2 Cr-Commit-Position: refs/heads/master@{#33867}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M src/builtins.cc View 1 1 chunk +29 lines, -5 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Toon Verwaest
ptal
4 years, 10 months ago (2016-02-10 11:05:53 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682873003/1
4 years, 10 months ago (2016-02-10 11:05:54 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682873003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682873003/20001
4 years, 10 months ago (2016-02-10 11:13:34 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-10 11:34:56 UTC) #8
Camillo Bruni
lgtm
4 years, 10 months ago (2016-02-10 12:21:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682873003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682873003/20001
4 years, 10 months ago (2016-02-10 13:48:40 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-10 13:49:57 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 13:50:27 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9ad61e6d81b8ff5c1391fb2b49b510daa15379d2
Cr-Commit-Position: refs/heads/master@{#33867}

Powered by Google App Engine
This is Rietveld 408576698