Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: ios/web/web_state/ui/crw_wk_web_view_web_controller.mm

Issue 1682873002: Set CRWWebViewContentView's size before resetting scroll proxy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added DCHECK, reset frame web view frame immediately from CRWWebViewContentView Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/web_state/ui/crw_wk_web_view_web_controller.mm
diff --git a/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm b/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm
index de29b293c2da896d3da9b639632678324333a1ba..7ecb0d445d9e3d2cca7dcae5b7ea203ccb53bc21 100644
--- a/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm
+++ b/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm
@@ -588,6 +588,8 @@ WKWebViewErrorSource WKWebViewErrorSourceFromError(NSError* error) {
- (void)loadRequestForCurrentNavigationItem {
DCHECK(self.webView && !self.nativeController);
DCHECK([self currentSessionEntry]);
+ DCHECK(CGRectGetWidth(self.webView.frame) > 0.0);
shreyasv1 2016/02/09 22:58:18 DCHECK_GE?
kkhorimoto 2016/02/10 00:08:36 Done.
+ DCHECK(CGRectGetHeight(self.webView.frame) > 0.0);
stuartmorgan 2016/02/09 23:00:51 CGRectIsNull? Also, a brief comment here explaini
kkhorimoto 2016/02/10 00:08:36 CGRectIsNull specifically checks against {{Inf, In
web::WKBackForwardListItemHolder* holder =
[self currentBackForwardListItemHolder];

Powered by Google App Engine
This is Rietveld 408576698