src/ia32/assembler-ia32-inl.h - Issue 1682853003: [debugger] introduce abstract interface for break location.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/assembler-ia32-inl.h

Issue 1682853003: [debugger] introduce abstract interface for break location. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: revert stray edit Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/assembler-ia32-inl.h

diff --git a/src/ia32/assembler-ia32-inl.h b/src/ia32/assembler-ia32-inl.h

index 77b55c644fb41cd11ebcf6888f84927d0d5673d9..cb6bad8a20f71f28c1c8c70cf8d8afee2a69e46c 100644

--- a/src/ia32/assembler-ia32-inl.h

+++ b/src/ia32/assembler-ia32-inl.h

@@ -266,16 +266,6 @@ void RelocInfo::WipeOut() {

}

-bool RelocInfo::IsPatchedReturnSequence() {

- return *pc_ == kCallOpcode;

-bool RelocInfo::IsPatchedDebugBreakSlotSequence() {

- return !Assembler::IsNop(pc());

void RelocInfo::Visit(Isolate* isolate, ObjectVisitor* visitor) {

RelocInfo::Mode mode = rmode();

if (mode == RelocInfo::EMBEDDED_OBJECT) {

« no previous file with comments | « src/factory.cc ('k') | src/interpreter/source-position-table.h » ('j') | no next file with comments »