src/debug/x87/debug-x87.cc - Issue 1682853003: [debugger] introduce abstract interface for break location.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/x87/debug-x87.cc

Issue 1682853003: [debugger] introduce abstract interface for break location. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: revert stray edit Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug/x87/debug-x87.cc

diff --git a/src/debug/x87/debug-x87.cc b/src/debug/x87/debug-x87.cc

index 8c04e02b89c0f4faf66fed9e44b3b4d81321fe70..8ddb82f39d4b24a9adc87360cca9ca6646145348 100644

--- a/src/debug/x87/debug-x87.cc

+++ b/src/debug/x87/debug-x87.cc

@@ -50,6 +50,9 @@ void DebugCodegen::PatchDebugBreakSlot(Isolate* isolate, Address pc,

DCHECK_EQ(kSize, patcher.masm()->SizeOfCodeGeneratedSince(&check_codesize));

}

+bool DebugCodegen::DebugBreakSlotIsPatched(Address pc) {

+ return !Assembler::IsNop(pc);

void DebugCodegen::GenerateDebugBreakStub(MacroAssembler* masm,

DebugBreakCallHelperMode mode) {

« no previous file with comments | « src/debug/x64/debug-x64.cc ('k') | src/factory.cc » ('j') | no next file with comments »