Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: src/debug/x87/debug-x87.cc

Issue 1682853003: [debugger] introduce abstract interface for break location. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: revert stray edit Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug/x64/debug-x64.cc ('k') | src/factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/x87/frames-x87.h" 9 #include "src/x87/frames-x87.h"
10 10
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 CodePatcher patcher(isolate, pc, kSize); 43 CodePatcher patcher(isolate, pc, kSize);
44 44
45 // Add a label for checking the size of the code used for returning. 45 // Add a label for checking the size of the code used for returning.
46 Label check_codesize; 46 Label check_codesize;
47 patcher.masm()->bind(&check_codesize); 47 patcher.masm()->bind(&check_codesize);
48 patcher.masm()->call(code->entry(), RelocInfo::NONE32); 48 patcher.masm()->call(code->entry(), RelocInfo::NONE32);
49 // Check that the size of the code generated is as expected. 49 // Check that the size of the code generated is as expected.
50 DCHECK_EQ(kSize, patcher.masm()->SizeOfCodeGeneratedSince(&check_codesize)); 50 DCHECK_EQ(kSize, patcher.masm()->SizeOfCodeGeneratedSince(&check_codesize));
51 } 51 }
52 52
53 bool DebugCodegen::DebugBreakSlotIsPatched(Address pc) {
54 return !Assembler::IsNop(pc);
55 }
53 56
54 void DebugCodegen::GenerateDebugBreakStub(MacroAssembler* masm, 57 void DebugCodegen::GenerateDebugBreakStub(MacroAssembler* masm,
55 DebugBreakCallHelperMode mode) { 58 DebugBreakCallHelperMode mode) {
56 __ RecordComment("Debug break"); 59 __ RecordComment("Debug break");
57 60
58 // Enter an internal frame. 61 // Enter an internal frame.
59 { 62 {
60 FrameScope scope(masm, StackFrame::INTERNAL); 63 FrameScope scope(masm, StackFrame::INTERNAL);
61 64
62 // Load padding words on stack. 65 // Load padding words on stack.
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 135
133 136
134 const bool LiveEdit::kFrameDropperSupported = true; 137 const bool LiveEdit::kFrameDropperSupported = true;
135 138
136 #undef __ 139 #undef __
137 140
138 } // namespace internal 141 } // namespace internal
139 } // namespace v8 142 } // namespace v8
140 143
141 #endif // V8_TARGET_ARCH_X87 144 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/debug/x64/debug-x64.cc ('k') | src/factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698