Fix nacl_helper CrOS GN build

Fix nacl_helper CrOS GN build

This fixes the following error in the CrOS ozone GN build
(target_os="chromeos" use_ozone="true"):

FAILED: ../third_party/llvm-build/Release+Asserts/bin/clang++ -pie -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -B../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold -Wl,--icf=all -pthread -m64 -Wl,-rpath-link=../out_gn_ozone -Wl,--disable-new-dtags -o "./nacl_helper" -Wl,--start-group @"./nacl_helper.rsp"  -Wl,--end-group  -ldl -lrt -lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4 -lfontconfig -lfreetype -lharfbuzz -ldbus-1 -lresolv -ldrm -lffi -lexpat -lasound -lm -lz
../content/common/child_process_sandbox_support_impl_linux.cc:69: error: undefined reference to 'blink::WebFontRenderStyle::setDefaults()'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: cannot make progress due to previous errors.

Committed: https://crrev.com/cec7034f9bf79cd145e0ddea36f201c2fc4d6da4
Cr-Commit-Position: refs/heads/master@{#374459}

[spang, 2016-02-09 18:47:34]

The CQ bit was checked by spang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-09 18:50:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1682843002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1682843002/1

[spang, 2016-02-09 19:33:09]

spang@chromium.org changed reviewers:
+ nick@chromium.org

[ncarter (slow), 2016-02-09 19:56:50]

nick@chromium.org changed reviewers:
+ jam@chromium.org

[ncarter (slow), 2016-02-09 19:56:50]

https://codereview.chromium.org/1682843002/diff/1/content/common/BUILD.gn
File content/common/BUILD.gn (right):

https://codereview.chromium.org/1682843002/diff/1/content/common/BUILD.gn#new...
content/common/BUILD.gn:168: "//third_party/WebKit/public:blink",
Adding jam@ for a second opinion.

This seems a little wrong to me, as code in content/common should not depend on
blink. We do not allow inclusion of WebKit from the browser, other than strictly
enum/POD, header-only types, and some selected common code.

However content_common.gypi appears to have this same dependency.

[spang, 2016-02-09 20:01:43]

On 2016/02/09 19:56:50, ncarter wrote:
> https://codereview.chromium.org/1682843002/diff/1/content/common/BUILD.gn
> File content/common/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1682843002/diff/1/content/common/BUILD.gn#new...
> content/common/BUILD.gn:168: "//third_party/WebKit/public:blink",
> Adding jam@ for a second opinion.
> 
> This seems a little wrong to me, as code in content/common should not depend
on
> blink. We do not allow inclusion of WebKit from the browser, other than
strictly
> enum/POD, header-only types, and some selected common code.
> 
> However content_common.gypi appears to have this same dependency.

The dependency is there; this is just documenting the status quo. GN build
should work these days or we cannot migrate.

[commit-bot: I haz the power, 2016-02-09 20:01:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 20:01:48]

Dry run: This issue passed the CQ dry run.

[ncarter (slow), 2016-02-09 20:08:19]

lgtm (to fix your build) but I'd still like jam's input, if only for my future
reference

[spang, 2016-02-09 20:24:38]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2016-02-09 20:26:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1682843002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1682843002/1

[commit-bot: I haz the power, 2016-02-09 20:36:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-09 20:38:03]

Description was changed from

==========
Fix nacl_helper CrOS GN build

This fixes the following error in the CrOS ozone GN build
(target_os="chromeos" use_ozone="true"):

FAILED: ../third_party/llvm-build/Release+Asserts/bin/clang++ -pie
-Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro
-Wl,-z,defs -B../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold
-Wl,--icf=all -pthread -m64 -Wl,-rpath-link=../out_gn_ozone
-Wl,--disable-new-dtags -o "./nacl_helper" -Wl,--start-group
@"./nacl_helper.rsp"  -Wl,--end-group  -ldl -lrt -lnss3 -lnssutil3 -lsmime3
-lplds4 -lplc4 -lnspr4 -lfontconfig -lfreetype -lharfbuzz -ldbus-1 -lresolv
-ldrm -lffi -lexpat -lasound -lm -lz
../content/common/child_process_sandbox_support_impl_linux.cc:69: error:
undefined reference to 'blink::WebFontRenderStyle::setDefaults()'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: cannot make progress due to previous errors.
==========

to

==========
Fix nacl_helper CrOS GN build

This fixes the following error in the CrOS ozone GN build
(target_os="chromeos" use_ozone="true"):

FAILED: ../third_party/llvm-build/Release+Asserts/bin/clang++ -pie
-Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro
-Wl,-z,defs -B../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold
-Wl,--icf=all -pthread -m64 -Wl,-rpath-link=../out_gn_ozone
-Wl,--disable-new-dtags -o "./nacl_helper" -Wl,--start-group
@"./nacl_helper.rsp"  -Wl,--end-group  -ldl -lrt -lnss3 -lnssutil3 -lsmime3
-lplds4 -lplc4 -lnspr4 -lfontconfig -lfreetype -lharfbuzz -ldbus-1 -lresolv
-ldrm -lffi -lexpat -lasound -lm -lz
../content/common/child_process_sandbox_support_impl_linux.cc:69: error:
undefined reference to 'blink::WebFontRenderStyle::setDefaults()'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: cannot make progress due to previous errors.

Committed: https://crrev.com/cec7034f9bf79cd145e0ddea36f201c2fc4d6da4
Cr-Commit-Position: refs/heads/master@{#374459}
==========

[commit-bot: I haz the power, 2016-02-09 20:38:04]

Patchset 1 (id:??) landed as
https://crrev.com/cec7034f9bf79cd145e0ddea36f201c2fc4d6da4
Cr-Commit-Position: refs/heads/master@{#374459}