Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1682833002: Fix liblouis GN build (Closed)

Created:
4 years, 10 months ago by spang
Modified:
4 years, 10 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix liblouis GN build This fixes the following error in the CrOS gn ozone build (target_os="chromeos" use_ozone=true): [2/2854] ACTION //third_party/liblouis:liblouis_tables(//build/toolchain/cros:clang_target) FAILED: python ../third_party/liblouis/copy_tables.py -D ../third_party/liblouis -D ../third_party/liblouis/src/tables -d resources/chromeos/chromevox/braille/tables -e ../../../../../../third_party/liblouis/cvox-common.cti --depfile gen/third_party/liblouis/liblouis_tables.d ../third_party/liblouis/tables.json liblouis_list_tables: File not found: ../../../../../../third_party/liblouis/cvox-common.cti Committed: https://crrev.com/0a40d5fc6506cde613b27dd96e3cbdae965caa38 Cr-Commit-Position: refs/heads/master@{#374577}

Patch Set 1 #

Patch Set 2 : relative to . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/liblouis/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682833002/1
4 years, 10 months ago (2016-02-09 18:44:36 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682833002/20001
4 years, 10 months ago (2016-02-09 18:50:30 UTC) #5
spang
4 years, 10 months ago (2016-02-09 19:33:45 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-09 20:01:45 UTC) #9
dmazzoni
lgtm
4 years, 10 months ago (2016-02-09 23:33:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682833002/20001
4 years, 10 months ago (2016-02-10 02:10:20 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-10 02:20:00 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 02:21:37 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0a40d5fc6506cde613b27dd96e3cbdae965caa38
Cr-Commit-Position: refs/heads/master@{#374577}

Powered by Google App Engine
This is Rietveld 408576698