Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 168283010: Avoid stack overflow write 1 in ipc fuzzer. (Closed)

Created:
6 years, 10 months ago by Tom Sepez
Modified:
5 years, 6 months ago
Reviewers:
aedla, Nico
CC:
chromium-reviews, inferno, Martin Barbella
Visibility:
Public.

Description

Avoid stack overflow write 1 in ipc fuzzer. Since IPC fuzzer compiles outside of the normal chromium build, there can be some symbols which we don't properly get defined, so define them locally for now. TBR=aedla@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252196

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M tools/ipc_fuzzer/message_lib/message_lib.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/ipc_fuzzer/mutate/mutate.gyp View 3 chunks +9 lines, -0 lines 0 comments Download
M tools/ipc_fuzzer/replay/replay.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (1 generated)
Tom Sepez
6 years, 10 months ago (2014-02-19 21:30:42 UTC) #1
Tom Sepez
The CQ bit was checked by tsepez@chromium.org
6 years, 10 months ago (2014-02-19 21:30:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/168283010/1
6 years, 10 months ago (2014-02-19 21:42:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/168283010/1
6 years, 10 months ago (2014-02-20 00:33:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/168283010/1
6 years, 10 months ago (2014-02-20 03:15:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/168283010/1
6 years, 10 months ago (2014-02-20 08:39:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/168283010/1
6 years, 10 months ago (2014-02-20 12:17:50 UTC) #7
commit-bot: I haz the power
Change committed as 252196
6 years, 10 months ago (2014-02-20 12:50:06 UTC) #8
Nico
Why is this needed? Nothing in ipc_fuzzer seems to check this symbol. (The CL description ...
5 years, 6 months ago (2015-06-01 21:42:27 UTC) #10
Tom Sepez
5 years, 6 months ago (2015-06-01 23:29:59 UTC) #11
Message was sent while issue was closed. 
On 2015/06/01 21:42:27, Nico wrote:
> Why is this needed? Nothing in ipc_fuzzer seems to check this symbol. (The CL
> description doesn't really say, and there's no BUG= line either…)

The IPC fuzzer includes headers that check this symbol.

Powered by Google App Engine
This is Rietveld 408576698