Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 168283003: Android: pass AutofillSuggestion to the logger. (Closed)

Created:
6 years, 10 months ago by bulach
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Android: pass AutofillSuggestion to the logger. BUG=341493 NOTRY=True NOTREECHECKS=true R=benm@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252037

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M ui/android/java/src/org/chromium/ui/autofill/AutofillPopup.java View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/autofill/AutofillSuggestion.java View 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
bulach
ptal
6 years, 10 months ago (2014-02-19 11:04:54 UTC) #1
benm (inactive)
lgtm
6 years, 10 months ago (2014-02-19 12:33:27 UTC) #2
bulach
The CQ bit was checked by bulach@chromium.org
6 years, 10 months ago (2014-02-19 14:02:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/168283003/1
6 years, 10 months ago (2014-02-19 14:02:31 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 14:06:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-19 14:06:14 UTC) #6
bulach
The CQ bit was checked by bulach@chromium.org
6 years, 10 months ago (2014-02-19 14:10:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/168283003/1
6 years, 10 months ago (2014-02-19 14:11:00 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 14:11:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-19 14:11:11 UTC) #10
bulach
going with notry, the try-bot failure is unrelated.
6 years, 10 months ago (2014-02-19 14:55:13 UTC) #11
bulach
The CQ bit was checked by bulach@chromium.org
6 years, 10 months ago (2014-02-19 14:55:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/168283003/1
6 years, 10 months ago (2014-02-19 15:08:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/168283003/1
6 years, 10 months ago (2014-02-19 15:36:36 UTC) #14
shashi
The CQ bit was unchecked by shashishekhar@chromium.org
6 years, 10 months ago (2014-02-19 18:38:57 UTC) #15
shashi
The CQ bit was checked by shashishekhar@chromium.org
6 years, 10 months ago (2014-02-19 18:39:01 UTC) #16
shashi
6 years, 10 months ago (2014-02-19 18:46:26 UTC) #17
Message was sent while issue was closed. 
Committed patchset #1 manually as r252037 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698