Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1682813002: Remove distiller dependency on bookmarks (Closed)

Created:
4 years, 10 months ago by mdjones
Modified:
4 years, 10 months ago
Reviewers:
wychen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove distiller dependency on bookmarks This change removes distiller's article sync dependency on the enhanced bookmarks experiment. BUG= Committed: https://crrev.com/6cb61123de1dfd590e9a3e646ab08e2cb7d37cd7 Cr-Commit-Position: refs/heads/master@{#375615}

Patch Set 1 #

Patch Set 2 : simplify logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -22 lines) Patch
M components/dom_distiller/core/dom_distiller_features.cc View 1 1 chunk +4 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mdjones
PTAL
4 years, 10 months ago (2016-02-09 18:26:20 UTC) #2
wychen
lgtm
4 years, 10 months ago (2016-02-09 21:22:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682813002/20001
4 years, 10 months ago (2016-02-16 18:06:16 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-16 19:06:42 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:53:43 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6cb61123de1dfd590e9a3e646ab08e2cb7d37cd7
Cr-Commit-Position: refs/heads/master@{#375615}

Powered by Google App Engine
This is Rietveld 408576698