Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1682803005: VM: Remove dead code from flow graph optimizer. (Closed)

Created:
4 years, 10 months ago by Florian Schneider
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : removed extra flag decl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -63 lines) Patch
M runtime/vm/compiler.cc View 2 chunks +3 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_optimizer.h View 4 chunks +0 lines, -9 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 6 chunks +20 lines, -51 lines 0 comments Download
M runtime/vm/precompiler.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
4 years, 10 months ago (2016-02-10 15:13:53 UTC) #2
Vyacheslav Egorov (Google)
lgtm
4 years, 10 months ago (2016-02-10 15:21:06 UTC) #3
Florian Schneider
4 years, 10 months ago (2016-02-10 15:25:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
29b6c0b5d77426f6afc8a5f58290b1b26ac8fc32 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698