cc: ImageDecodes: handle low quality filters.

cc/tiles/image_decode_controller_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/tiles/image_decode_controller.h"
 
 #include "cc/playback/draw_image.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace cc {
@@ skipping 14 matching lines @@
   for (auto quality : qualities) {
     DrawImage draw_image(
         image.get(), SkIRect::MakeWH(image->width(), image->height()),
         SkSize::Make(0.5f, 1.5f), quality, has_perspective, is_decomposable);
 
     auto key = ImageDecodeControllerKey::FromDrawImage(draw_image);
     EXPECT_EQ(image->uniqueID(), key.image_id());
     EXPECT_EQ(quality, key.filter_quality());
     EXPECT_EQ(50, key.target_size().width());
     EXPECT_EQ(150, key.target_size().height());
-    EXPECT_EQ(50u * 150u * 4u, key.target_bytes());
+    EXPECT_TRUE(key.can_use_original_decode());
+    // Since the original decode will be used, the locked_bytes is that of the
+    // original image.
+    EXPECT_EQ(100u * 100u * 4u, key.locked_bytes());
   }
 }
 
 TEST(ImageDecodeControllerTest, ImageKeyMediumQuality) {
   skia::RefPtr<SkImage> image = CreateImage(100, 100);
   bool has_perspective = false;
   bool is_decomposable = true;
   SkFilterQuality quality = kMedium_SkFilterQuality;
 
   DrawImage draw_image(
       image.get(), SkIRect::MakeWH(image->width(), image->height()),
       SkSize::Make(0.5f, 1.5f), quality, has_perspective, is_decomposable);
 
   auto key = ImageDecodeControllerKey::FromDrawImage(draw_image);
   EXPECT_EQ(image->uniqueID(), key.image_id());
   EXPECT_EQ(quality, key.filter_quality());
   EXPECT_EQ(50, key.target_size().width());
   EXPECT_EQ(150, key.target_size().height());
-  EXPECT_EQ(50u * 150u * 4u, key.target_bytes());
+  EXPECT_FALSE(key.can_use_original_decode());
+  EXPECT_EQ(50u * 150u * 4u, key.locked_bytes());
 }
 
 TEST(ImageDecodeControllerTest, ImageKeyMediumQualityEvenWithPerspective) {
   skia::RefPtr<SkImage> image = CreateImage(100, 100);
   bool has_perspective = true;
   bool is_decomposable = true;
   SkFilterQuality quality = kMedium_SkFilterQuality;
 
   DrawImage draw_image(
       image.get(), SkIRect::MakeWH(image->width(), image->height()),
       SkSize::Make(0.5f, 1.5f), quality, has_perspective, is_decomposable);
 
   auto key = ImageDecodeControllerKey::FromDrawImage(draw_image);
   EXPECT_EQ(image->uniqueID(), key.image_id());
   EXPECT_EQ(quality, key.filter_quality());
   EXPECT_EQ(50, key.target_size().width());
   EXPECT_EQ(150, key.target_size().height());
-  EXPECT_EQ(50u * 150u * 4u, key.target_bytes());
+  EXPECT_FALSE(key.can_use_original_decode());
+  EXPECT_EQ(50u * 150u * 4u, key.locked_bytes());
 }
 
 TEST(ImageDecodeControllerTest, ImageKeyMediumQualityDropToLowIfEnlarging) {
   skia::RefPtr<SkImage> image = CreateImage(100, 100);
   bool has_perspective = false;
   bool is_decomposable = true;
   SkFilterQuality quality = kMedium_SkFilterQuality;
 
   DrawImage draw_image(
       image.get(), SkIRect::MakeWH(image->width(), image->height()),
       SkSize::Make(1.5f, 1.5f), quality, has_perspective, is_decomposable);
 
   auto key = ImageDecodeControllerKey::FromDrawImage(draw_image);
   EXPECT_EQ(image->uniqueID(), key.image_id());
   EXPECT_EQ(kLow_SkFilterQuality, key.filter_quality());
   EXPECT_EQ(150, key.target_size().width());
   EXPECT_EQ(150, key.target_size().height());
-  EXPECT_EQ(150u * 150u * 4u, key.target_bytes());
+  EXPECT_TRUE(key.can_use_original_decode());
+  EXPECT_EQ(100u * 100u * 4u, key.locked_bytes());
 }
 
 TEST(ImageDecodeControllerTest, ImageKeyMediumQualityDropToLowIfIdentity) {
   skia::RefPtr<SkImage> image = CreateImage(100, 100);
   bool has_perspective = false;
   bool is_decomposable = true;
   SkFilterQuality quality = kMedium_SkFilterQuality;
 
   DrawImage draw_image(
       image.get(), SkIRect::MakeWH(image->width(), image->height()),
       SkSize::Make(1.f, 1.f), quality, has_perspective, is_decomposable);
 
   auto key = ImageDecodeControllerKey::FromDrawImage(draw_image);
   EXPECT_EQ(image->uniqueID(), key.image_id());
   EXPECT_EQ(kLow_SkFilterQuality, key.filter_quality());
   EXPECT_EQ(100, key.target_size().width());
   EXPECT_EQ(100, key.target_size().height());
-  EXPECT_EQ(100u * 100u * 4u, key.target_bytes());
+  EXPECT_TRUE(key.can_use_original_decode());
+  EXPECT_EQ(100u * 100u * 4u, key.locked_bytes());
 }
 
 TEST(ImageDecodeControllerTest,
      ImageKeyMediumQualityDropToLowIfNearlyIdentity) {
   skia::RefPtr<SkImage> image = CreateImage(100, 100);
   bool has_perspective = false;
   bool is_decomposable = true;
   SkFilterQuality quality = kMedium_SkFilterQuality;
 
   DrawImage draw_image(
       image.get(), SkIRect::MakeWH(image->width(), image->height()),
       SkSize::Make(1.001f, 1.001f), quality, has_perspective, is_decomposable);
 
   auto key = ImageDecodeControllerKey::FromDrawImage(draw_image);
   EXPECT_EQ(image->uniqueID(), key.image_id());
   EXPECT_EQ(kLow_SkFilterQuality, key.filter_quality());
   EXPECT_EQ(100, key.target_size().width());
   EXPECT_EQ(100, key.target_size().height());
-  EXPECT_EQ(100u * 100u * 4u, key.target_bytes());
+  EXPECT_TRUE(key.can_use_original_decode());
+  EXPECT_EQ(100u * 100u * 4u, key.locked_bytes());
 }
 
 TEST(ImageDecodeControllerTest,
      ImageKeyMediumQualityDropToLowIfNearlyIdentity2) {
   skia::RefPtr<SkImage> image = CreateImage(100, 100);
   bool has_perspective = false;
   bool is_decomposable = true;
   SkFilterQuality quality = kMedium_SkFilterQuality;
 
   DrawImage draw_image(
       image.get(), SkIRect::MakeWH(image->width(), image->height()),
       SkSize::Make(0.999f, 0.999f), quality, has_perspective, is_decomposable);
 
   auto key = ImageDecodeControllerKey::FromDrawImage(draw_image);
   EXPECT_EQ(image->uniqueID(), key.image_id());
   EXPECT_EQ(kLow_SkFilterQuality, key.filter_quality());
   EXPECT_EQ(100, key.target_size().width());
   EXPECT_EQ(100, key.target_size().height());
-  EXPECT_EQ(100u * 100u * 4u, key.target_bytes());
+  EXPECT_TRUE(key.can_use_original_decode());
+  EXPECT_EQ(100u * 100u * 4u, key.locked_bytes());
 }
 
 TEST(ImageDecodeControllerTest,
      ImageKeyMediumQualityDropToLowIfNotDecomposable) {
   skia::RefPtr<SkImage> image = CreateImage(100, 100);
   bool has_perspective = false;
   bool is_decomposable = false;
   SkFilterQuality quality = kMedium_SkFilterQuality;
 
   DrawImage draw_image(
       image.get(), SkIRect::MakeWH(image->width(), image->height()),
       SkSize::Make(0.5f, 1.5f), quality, has_perspective, is_decomposable);
 
   auto key = ImageDecodeControllerKey::FromDrawImage(draw_image);
   EXPECT_EQ(image->uniqueID(), key.image_id());
   EXPECT_EQ(kLow_SkFilterQuality, key.filter_quality());
   EXPECT_EQ(50, key.target_size().width());
   EXPECT_EQ(150, key.target_size().height());
-  EXPECT_EQ(50u * 150u * 4u, key.target_bytes());
+  EXPECT_TRUE(key.can_use_original_decode());
+  EXPECT_EQ(100u * 100u * 4u, key.locked_bytes());
 }
 
 TEST(ImageDecodeControllerTest, ImageKeyHighQuality) {
   skia::RefPtr<SkImage> image = CreateImage(100, 100);
   bool has_perspective = false;
   bool is_decomposable = true;
   SkFilterQuality quality = kHigh_SkFilterQuality;
 
   DrawImage draw_image(
       image.get(), SkIRect::MakeWH(image->width(), image->height()),
       SkSize::Make(0.5f, 1.5f), quality, has_perspective, is_decomposable);
 
   auto key = ImageDecodeControllerKey::FromDrawImage(draw_image);
   EXPECT_EQ(image->uniqueID(), key.image_id());
   EXPECT_EQ(quality, key.filter_quality());
   EXPECT_EQ(50, key.target_size().width());
   EXPECT_EQ(150, key.target_size().height());
-  EXPECT_EQ(50u * 150u * 4u, key.target_bytes());
+  EXPECT_FALSE(key.can_use_original_decode());
+  EXPECT_EQ(50u * 150u * 4u, key.locked_bytes());
 }
 
 TEST(ImageDecodeControllerTest,
      ImageKeyHighQualityDropToMediumWithPerspective) {
   skia::RefPtr<SkImage> image = CreateImage(100, 100);
   bool has_perspective = true;
   bool is_decomposable = true;
   SkFilterQuality quality = kHigh_SkFilterQuality;
 
   DrawImage draw_image(
       image.get(), SkIRect::MakeWH(image->width(), image->height()),
       SkSize::Make(0.5f, 1.5f), quality, has_perspective, is_decomposable);
 
   auto key = ImageDecodeControllerKey::FromDrawImage(draw_image);
   EXPECT_EQ(image->uniqueID(), key.image_id());
   EXPECT_EQ(kMedium_SkFilterQuality, key.filter_quality());
   EXPECT_EQ(50, key.target_size().width());
   EXPECT_EQ(150, key.target_size().height());
-  EXPECT_EQ(50u * 150u * 4u, key.target_bytes());
+  EXPECT_FALSE(key.can_use_original_decode());
+  EXPECT_EQ(50u * 150u * 4u, key.locked_bytes());
 }
 
 TEST(ImageDecodeControllerTest, ImageKeyHighQualityDropToMediumIfTooLarge) {
   // Just over 64MB when scaled.
   skia::RefPtr<SkImage> image = CreateImage(4555, 2048);
   bool has_perspective = false;
   bool is_decomposable = true;
   SkFilterQuality quality = kHigh_SkFilterQuality;
 
   // At least one dimension should scale down, so that medium quality doesn't
   // become low.
   DrawImage draw_image(
       image.get(), SkIRect::MakeWH(image->width(), image->height()),
       SkSize::Make(0.9f, 2.f), quality, has_perspective, is_decomposable);
 
   auto key = ImageDecodeControllerKey::FromDrawImage(draw_image);
   EXPECT_EQ(image->uniqueID(), key.image_id());
   EXPECT_EQ(kMedium_SkFilterQuality, key.filter_quality());
   EXPECT_EQ(4100, key.target_size().width());
   EXPECT_EQ(4096, key.target_size().height());
-  EXPECT_EQ(4100u * 4096u * 4u, key.target_bytes());
+  EXPECT_FALSE(key.can_use_original_decode());
+  EXPECT_EQ(4100u * 4096u * 4u, key.locked_bytes());
 }
 
 TEST(ImageDecodeControllerTest, ImageKeyHighQualityDropToLowIfNotDecomposable) {
   skia::RefPtr<SkImage> image = CreateImage(100, 100);
   bool has_perspective = false;
   bool is_decomposable = false;
   SkFilterQuality quality = kHigh_SkFilterQuality;
 
   DrawImage draw_image(
       image.get(), SkIRect::MakeWH(image->width(), image->height()),
       SkSize::Make(0.5f, 1.5f), quality, has_perspective, is_decomposable);
 
   auto key = ImageDecodeControllerKey::FromDrawImage(draw_image);
   EXPECT_EQ(image->uniqueID(), key.image_id());
   EXPECT_EQ(kLow_SkFilterQuality, key.filter_quality());
   EXPECT_EQ(50, key.target_size().width());
   EXPECT_EQ(150, key.target_size().height());
-  EXPECT_EQ(50u * 150u * 4u, key.target_bytes());
+  EXPECT_TRUE(key.can_use_original_decode());
+  EXPECT_EQ(100u * 100u * 4u, key.locked_bytes());
 }
 
 TEST(ImageDecodeControllerTest, ImageKeyHighQualityDropToLowIfIdentity) {
   skia::RefPtr<SkImage> image = CreateImage(100, 100);
   bool has_perspective = false;
   bool is_decomposable = true;
   SkFilterQuality quality = kHigh_SkFilterQuality;
 
   DrawImage draw_image(
       image.get(), SkIRect::MakeWH(image->width(), image->height()),
       SkSize::Make(1.f, 1.f), quality, has_perspective, is_decomposable);
 
   auto key = ImageDecodeControllerKey::FromDrawImage(draw_image);
   EXPECT_EQ(image->uniqueID(), key.image_id());
   EXPECT_EQ(kLow_SkFilterQuality, key.filter_quality());
   EXPECT_EQ(100, key.target_size().width());
   EXPECT_EQ(100, key.target_size().height());
-  EXPECT_EQ(100u * 100u * 4u, key.target_bytes());
+  EXPECT_TRUE(key.can_use_original_decode());
+  EXPECT_EQ(100u * 100u * 4u, key.locked_bytes());
 }
 
 TEST(ImageDecodeControllerTest, ImageKeyHighQualityDropToLowIfNearlyIdentity) {
   skia::RefPtr<SkImage> image = CreateImage(100, 100);
   bool has_perspective = false;
   bool is_decomposable = true;
   SkFilterQuality quality = kHigh_SkFilterQuality;
 
   DrawImage draw_image(
       image.get(), SkIRect::MakeWH(image->width(), image->height()),
       SkSize::Make(1.001f, 1.001f), quality, has_perspective, is_decomposable);
 
   auto key = ImageDecodeControllerKey::FromDrawImage(draw_image);
   EXPECT_EQ(image->uniqueID(), key.image_id());
   EXPECT_EQ(kLow_SkFilterQuality, key.filter_quality());
   EXPECT_EQ(100, key.target_size().width());
   EXPECT_EQ(100, key.target_size().height());
-  EXPECT_EQ(100u * 100u * 4u, key.target_bytes());
+  EXPECT_TRUE(key.can_use_original_decode());
+  EXPECT_EQ(100u * 100u * 4u, key.locked_bytes());
 }
 
 TEST(ImageDecodeControllerTest, ImageKeyHighQualityDropToLowIfNearlyIdentity2) {
   skia::RefPtr<SkImage> image = CreateImage(100, 100);
   bool has_perspective = false;
   bool is_decomposable = true;
   SkFilterQuality quality = kHigh_SkFilterQuality;
 
   DrawImage draw_image(
       image.get(), SkIRect::MakeWH(image->width(), image->height()),
       SkSize::Make(0.999f, 0.999f), quality, has_perspective, is_decomposable);
 
   auto key = ImageDecodeControllerKey::FromDrawImage(draw_image);
   EXPECT_EQ(image->uniqueID(), key.image_id());
   EXPECT_EQ(kLow_SkFilterQuality, key.filter_quality());
   EXPECT_EQ(100, key.target_size().width());
   EXPECT_EQ(100, key.target_size().height());
-  EXPECT_EQ(100u * 100u * 4u, key.target_bytes());
+  EXPECT_TRUE(key.can_use_original_decode());
+  EXPECT_EQ(100u * 100u * 4u, key.locked_bytes());
+}
+
+TEST(ImageDecodeControllerTest, OriginalDecodesAreEqual) {
+  skia::RefPtr<SkImage> image = CreateImage(100, 100);
+  bool has_perspective = false;
+  bool is_decomposable = true;
+  SkFilterQuality quality = kLow_SkFilterQuality;
+
+  DrawImage draw_image(
+      image.get(), SkIRect::MakeWH(image->width(), image->height()),
+      SkSize::Make(0.5f, 0.5), quality, has_perspective, is_decomposable);
+
+  auto key = ImageDecodeControllerKey::FromDrawImage(draw_image);
+  EXPECT_EQ(image->uniqueID(), key.image_id());
+  EXPECT_EQ(kLow_SkFilterQuality, key.filter_quality());
+  EXPECT_EQ(50, key.target_size().width());
+  EXPECT_EQ(50, key.target_size().height());
+  EXPECT_TRUE(key.can_use_original_decode());
+  EXPECT_EQ(100u * 100u * 4u, key.locked_bytes());
+
+  DrawImage another_draw_image(
+      image.get(), SkIRect::MakeWH(image->width(), image->height()),
+      SkSize::Make(1.5f, 1.5), quality, has_perspective, is_decomposable);
+
+  auto another_key =
+      ImageDecodeControllerKey::FromDrawImage(another_draw_image);
+  EXPECT_EQ(image->uniqueID(), another_key.image_id());
+  EXPECT_EQ(kLow_SkFilterQuality, another_key.filter_quality());
+  EXPECT_EQ(150, another_key.target_size().width());
+  EXPECT_EQ(150, another_key.target_size().height());
+  EXPECT_TRUE(another_key.can_use_original_decode());
+  EXPECT_EQ(100u * 100u * 4u, another_key.locked_bytes());
+
+  EXPECT_TRUE(key == another_key);
 }
 
 TEST(ImageDecodeControllerTest, GetTaskForImageSameImage) {
   ImageDecodeController controller;
   skia::RefPtr<SkImage> image = CreateImage(100, 100);
   bool has_perspective = false;
   bool is_decomposable = true;
   SkFilterQuality quality = kHigh_SkFilterQuality;
   uint64_t prepare_tiles_id = 1;
 
@@ skipping 50 matching lines @@
   EXPECT_TRUE(medium_quality_task);
   EXPECT_TRUE(high_quality_task.get() != medium_quality_task.get());
 
   DrawImage low_quality_draw_image(
       image.get(), SkIRect::MakeWH(image->width(), image->height()),
       SkSize::Make(0.5f, 0.5f), kLow_SkFilterQuality, has_perspective,
       is_decomposable);
   scoped_refptr<ImageDecodeTask> low_quality_task;
   need_unref = controller.GetTaskForImageAndRef(
       low_quality_draw_image, prepare_tiles_id, &low_quality_task);
-  // Note that when we pin the original decode, we might ref low quality images
-  // too, but we don't support that right now.
-  EXPECT_FALSE(need_unref);
+  EXPECT_TRUE(need_unref);
   EXPECT_TRUE(low_quality_task);
   EXPECT_TRUE(high_quality_task.get() != low_quality_task.get());
   EXPECT_TRUE(medium_quality_task.get() != low_quality_task.get());
 
   controller.UnrefImage(high_quality_draw_image);
+  controller.UnrefImage(low_quality_draw_image);
 }
 
 TEST(ImageDecodeControllerTest, GetTaskForImageSameImageDifferentSize) {
   ImageDecodeController controller;
   skia::RefPtr<SkImage> image = CreateImage(100, 100);
   bool has_perspective = false;
   bool is_decomposable = true;
   uint64_t prepare_tiles_id = 1;
   SkFilterQuality quality = kHigh_SkFilterQuality;
 
@@ skipping 97 matching lines @@
   uint64_t prepare_tiles_id = 1;
   SkFilterQuality quality = kLow_SkFilterQuality;
 
   skia::RefPtr<SkImage> image = CreateImage(100, 100);
   DrawImage draw_image(
       image.get(), SkIRect::MakeWH(image->width(), image->height()),
       SkSize::Make(1.f, 1.f), quality, has_perspective, is_decomposable);
   scoped_refptr<ImageDecodeTask> task;
   bool need_unref =
       controller.GetTaskForImageAndRef(draw_image, prepare_tiles_id, &task);
-  // We're not currently locking original scale or low quality images.
-  EXPECT_FALSE(need_unref);
+  EXPECT_TRUE(need_unref);
   EXPECT_TRUE(task);
 
   task->WillSchedule();
   task->ScheduleOnOriginThread(nullptr);
   task->DidSchedule();
   task->RunOnWorkerThread();
 
   scoped_refptr<ImageDecodeTask> another_task;
   need_unref = controller.GetTaskForImageAndRef(draw_image, prepare_tiles_id,
                                                 &another_task);
-  EXPECT_FALSE(need_unref);
+  EXPECT_TRUE(need_unref);
   EXPECT_FALSE(another_task);
 
   task->WillComplete();
   task->CompleteOnOriginThread(nullptr);
   task->DidComplete();
 
   scoped_refptr<ImageDecodeTask> third_task;
   need_unref = controller.GetTaskForImageAndRef(draw_image, prepare_tiles_id,
                                                 &third_task);
-  EXPECT_FALSE(need_unref);
+  EXPECT_TRUE(need_unref);
   EXPECT_FALSE(third_task);
+
+  controller.UnrefImage(draw_image);
+  controller.UnrefImage(draw_image);
+  controller.UnrefImage(draw_image);
 }
 
 TEST(ImageDecodeControllerTest, GetTaskForImageCanceledGetsNewTask) {
   ImageDecodeController controller;
   bool has_perspective = false;
   bool is_decomposable = true;
   uint64_t prepare_tiles_id = 1;
   SkFilterQuality quality = kHigh_SkFilterQuality;
 
   skia::RefPtr<SkImage> image = CreateImage(100, 100);
@@ skipping 311 matching lines @@
   EXPECT_FALSE(task);
   EXPECT_FALSE(need_unref);
 
   DecodedDrawImage decoded_draw_image =
       controller.GetDecodedImageForDraw(draw_image);
   EXPECT_FALSE(decoded_draw_image.image());
 
   controller.DrawWithImageFinished(draw_image, decoded_draw_image);
 }
 
+TEST(ImageDecodeControllerTest, LowQualityFilterIsHandled) {
+  ImageDecodeController controller;
+  bool has_perspective = false;
+  bool is_decomposable = true;
+  uint64_t prepare_tiles_id = 1;
+  SkFilterQuality quality = kLow_SkFilterQuality;
+
+  skia::RefPtr<SkImage> image = CreateImage(100, 100);
+  DrawImage draw_image(
+      image.get(), SkIRect::MakeWH(image->width(), image->height()),
+      SkSize::Make(1.f, 1.f), quality, has_perspective, is_decomposable);
+
+  scoped_refptr<ImageDecodeTask> task;
+  bool need_unref =
+      controller.GetTaskForImageAndRef(draw_image, prepare_tiles_id, &task);
+  EXPECT_TRUE(task);
+  EXPECT_TRUE(need_unref);
+
+  DecodedDrawImage decoded_draw_image =
+      controller.GetDecodedImageForDraw(draw_image);
+  EXPECT_TRUE(decoded_draw_image.image());
+  // If we decoded the image and cached it, it would be stored in a different
+  // SkImage object.
+  EXPECT_TRUE(decoded_draw_image.image() != image.get());
+
+  controller.DrawWithImageFinished(draw_image, decoded_draw_image);
+  controller.UnrefImage(draw_image);
+}
+
 }  // namespace
 }  // namespace cc