Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1682783002: Dartium 45 roll (Closed)

Created:
4 years, 10 months ago by Jacob
Modified:
4 years, 10 months ago
Reviewers:
Alan Knight, terry
CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : removed some changes that shouldn't be merged forward #

Patch Set 3 : removed htmlcommon #

Total comments: 1

Patch Set 4 : removed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+737 lines, -337 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/bin.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/bin/zlib.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/dartium/archive.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/dartium/test.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/dartium/update_deps.py View 2 chunks +5 lines, -4 lines 0 comments Download
M tools/deps/dartium.deps/DEPS View 2 chunks +24 lines, -25 lines 0 comments Download
M tools/deps/dartium.deps/DEPS.chromium View 25 chunks +231 lines, -233 lines 0 comments Download
M tools/dom/new_scripts/dart_utilities.py View 1 chunk +0 lines, -1 line 0 comments Download
A tools/dom/new_scripts/dependency.py View 1 chunk +9 lines, -0 lines 0 comments Download
M tools/dom/scripts/dartdomgenerator.py View 7 chunks +32 lines, -6 lines 0 comments Download
M tools/dom/scripts/dartgenerator.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/dom/scripts/database.py View 3 chunks +26 lines, -0 lines 0 comments Download
M tools/dom/scripts/databasebuilder.py View 7 chunks +22 lines, -10 lines 0 comments Download
M tools/dom/scripts/fremontcutbuilder.py View 2 chunks +2 lines, -0 lines 0 comments Download
A tools/dom/scripts/generate_blink_file.py View 1 chunk +275 lines, -0 lines 0 comments Download
M tools/dom/scripts/generator.py View 4 chunks +32 lines, -3 lines 0 comments Download
M tools/dom/scripts/go.sh View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 4 chunks +27 lines, -13 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/dom/scripts/idlnode.py View 8 chunks +26 lines, -15 lines 0 comments Download
M tools/dom/scripts/idlsync.py View 6 chunks +12 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jacob
4 years, 10 months ago (2016-02-09 18:08:58 UTC) #2
Alan Knight
lgtm https://codereview.chromium.org/1682783002/diff/40001/tools/dom/dom.json File tools/dom/dom.json (right): https://codereview.chromium.org/1682783002/diff/40001/tools/dom/dom.json#newcode91 tools/dom/dom.json:91: "Animation": {}, Is this file changed because of ...
4 years, 10 months ago (2016-02-09 18:45:51 UTC) #3
Jacob
On 2016/02/09 18:45:51, Alan Knight wrote: > lgtm > > https://codereview.chromium.org/1682783002/diff/40001/tools/dom/dom.json > File tools/dom/dom.json (right): ...
4 years, 10 months ago (2016-02-09 18:49:38 UTC) #4
Jacob
4 years, 10 months ago (2016-02-09 18:50:48 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
f478562b0a377b46c767403734e89914f07d67df (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698